[PATCH][MIPS] bcm47xx: remove unneeded clear_c0

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH][MIPS] bcm47xx: remove unneeded clear_c0_status()
@ 2007-11-01 12:30 Yoichi Yuasa
  2007-11-01 13:03 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2007-11-01 12:30 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: yoichi_yuasa, linux-mips

Remove unneeded clear_c0_status().
irq_cpu routines take care of it.

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/bcm47xx/irq.c mips/arch/mips/bcm47xx/irq.c
--- mips-orig/arch/mips/bcm47xx/irq.c	2007-10-26 23:35:58.630600250 +0900
+++ mips/arch/mips/bcm47xx/irq.c	2007-10-26 23:40:22.587096500 +0900
@@ -33,8 +33,6 @@ void plat_irq_dispatch(void)
 
 	cause = read_c0_cause() & read_c0_status() & CAUSEF_IP;
 
-	clear_c0_status(cause);
-
 	if (cause & CAUSEF_IP7)
 		do_IRQ(7);
 	if (cause & CAUSEF_IP2)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][MIPS] bcm47xx: remove unneeded clear_c0_status()
  2007-11-01 12:30 [PATCH][MIPS] bcm47xx: remove unneeded clear_c0_status() Yoichi Yuasa
@ 2007-11-01 13:03 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2007-11-01 13:03 UTC (permalink / raw)
  To: Yoichi Yuasa; +Cc: linux-mips

On Thu, Nov 01, 2007 at 09:30:36PM +0900, Yoichi Yuasa wrote:

> Remove unneeded clear_c0_status().
> irq_cpu routines take care of it.

Actually this write is plain nonsense; it has no effect.  The only time
acknowledging an interrupt in c0_cause is needed is for the two software
interrupts but the only user of these is SMTC.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-01 13:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-01 12:30 [PATCH][MIPS] bcm47xx: remove unneeded clear_c0_status() Yoichi Yuasa
2007-11-01 13:03 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.