From: "Dale Farnsworth" <dale@farnsworth.org>
To: tnt@blacksnow.net
Cc: linuxppc-dev@ozlabs.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings
Date: 1 Nov 2007 06:46:42 -0700 [thread overview]
Message-ID: <20071101134642.6257.qmail@farnsworth.org> (raw)
In-Reply-To: <52304.213.186.37.16.1193915988.squirrel@www.opensources.be>
Sylvain Munaut wrote:
> > Valentine Barshak wrote:
> >> Rework ohci-ppc-of driver to use big-endian property instead of
> >> ohci-be/ohci-le compatible strings. Also remove unnecessary
> >> user-selectable USB_OHCI_HCD_PPC_OF_LE/BE stuff, because
> >> USB_OHCI_BIG_ENDIAN_DESC/MMIO should always be enabled for ppc
> >> and USB_OHCI_LITTLE_ENDIAN is selected for USB_OHCI_HCD_PCI by default.
>
> I don't find those options useless. If you think the defauts are not the
> best change them but I find these options relevant. You don't always want
> the support for BE on PPC ... if the only controller you have is pci ...
> or if you're on a soc that use little endian ...
USB_OHCI_LITTLE_ENDIAN and USB_OHCI_BIG_ENDIAN are useful and I
don't see anyone wanting to remove them. However, if all of the
chips supported by the ohci-ppc-of driver are big-endian, then
USB_OHCI_HCD_PPC_OF_LE and USB_OHCI_HCD_PPC_OF_BE are not needed.
Just select USB_OHCI_BIG_ENDIAN when the ohci-ppc-of driver is
selected, in the same way that we always select USB_OHCI_LITTLE_ENDIAN
when the ohci-pci driver is selected.
-Dale
next prev parent reply other threads:[~2007-11-01 13:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:22 [PATCH 0/2] USB: Rework OHCI PPC OF driver to support new bindings Valentine Barshak
2007-10-24 16:34 ` [PATCH 1/2] USB: Rework OHCI PPC OF for " Valentine Barshak
2007-10-24 22:05 ` Matt Sealey
2007-10-25 1:50 ` [linux-usb-devel] " David Brownell
2007-10-25 2:41 ` Grant Likely
2007-10-25 11:48 ` Valentine Barshak
2007-10-25 14:21 ` Grant Likely
2007-10-25 17:11 ` Valentine Barshak
2007-10-25 18:14 ` Matt Sealey
2007-10-25 18:13 ` Valentine Barshak
2007-10-25 18:10 ` Matt Sealey
2007-10-25 18:01 ` Matt Sealey
2007-10-25 18:50 ` Valentine Barshak
2007-10-25 22:02 ` Matt Sealey
2007-10-26 11:24 ` Valentine Barshak
2007-10-26 12:13 ` Valentine Barshak
2007-11-01 11:19 ` tnt
2007-11-01 12:44 ` Valentine Barshak
2007-11-01 13:46 ` Dale Farnsworth [this message]
2007-10-24 16:35 ` [PATCH 2/2] PowerPC: Update USB OHCI DTS entires " Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101134642.6257.qmail@farnsworth.org \
--to=dale@farnsworth.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=tnt@blacksnow.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.