From: David Brownell <david-b@pacbell.net>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
jgarzik@pobox.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] let USB_USBNET always select MII
Date: Thu, 1 Nov 2007 16:52:39 -0700 [thread overview]
Message-ID: <200711011652.39601.david-b@pacbell.net> (raw)
In-Reply-To: <20071101222524.GB7227@stusta.de>
On Thursday 01 November 2007, Adrian Bunk wrote:
> All this USB_USBNET_MII trickery is simply not worth it considering how
> few code it saves.
Depends on what systems you're talking about. Forcing unused
code into the kernel is not free, especially if that's made into
a design policy and applied repeatedly to many subsystems.
> As a side effect, this also fixes the following compile error reported
> by Toralf Förster:
Why not just fix the thing which changed and broke the build?
Or if reverse dependencies can't be made to work sanely, then
have those Ethernet-adapter minidrivers depend on NET_ETHERNET
and then select MII. (To make the relationships be simple
enough that current Kconfig can handle them.)
I have a fair number of usbnet devices. Not one of them needs
MII or NET_ETHERNET.
- Dave
next prev parent reply other threads:[~2007-11-01 23:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 19:24 build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Toralf Förster
2007-11-01 21:11 ` Randy Dunlap
2007-11-01 23:32 ` David Brownell
2007-11-01 23:44 ` Adrian Bunk
2007-11-02 18:45 ` David Brownell
2007-11-02 18:57 ` Adrian Bunk
2007-11-02 19:30 ` David Brownell
2007-11-02 19:55 ` Adrian Bunk
2007-11-07 22:34 ` David Brownell
2007-11-07 22:52 ` Adrian Bunk
2007-11-08 2:53 ` David Brownell
2007-11-08 3:23 ` Adrian Bunk
2007-11-08 3:30 ` Adrian Bunk
2007-11-08 16:08 ` Randy Dunlap
2007-11-20 5:26 ` David Miller
2007-11-25 16:30 ` [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess Adrian Bunk
2007-11-26 15:19 ` Herbert Xu
2007-11-26 20:25 ` Adrian Bunk
2007-11-02 20:05 ` build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Adrian Bunk
2007-11-07 8:20 ` David Miller
2007-11-07 22:15 ` David Brownell
2007-11-01 22:25 ` [2.6 patch] let USB_USBNET always select MII Adrian Bunk
2007-11-01 23:52 ` David Brownell [this message]
2007-11-02 15:46 ` [2.6 patch] usbnet.c: check for the right MII variable Adrian Bunk
2007-11-07 22:31 ` David Brownell
2007-11-07 8:10 ` [2.6 patch] let USB_USBNET always select MII David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711011652.39601.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=bunk@kernel.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.