From: Adrian Bunk <bunk@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
david-b@pacbell.net, randy.dunlap@oracle.com,
toralf.foerster@gmx.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess
Date: Mon, 26 Nov 2007 21:25:47 +0100 [thread overview]
Message-ID: <20071126202547.GB917@stusta.de> (raw)
In-Reply-To: <20071126151926.GD28022@gondor.apana.org.au>
On Mon, Nov 26, 2007 at 11:19:26PM +0800, Herbert Xu wrote:
> On Sun, Nov 25, 2007 at 04:30:03PM +0000, Adrian Bunk wrote:
> > > >
> > > > Please look at net/ipv4/arp.c:arp_process()
> > > >
> > > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or
> > > > CONFIG_NETDEV_10000=y will not be handled correctly there?
> > > >
> > > > And the best solution is to nuke all #ifdef's in this function and make
> > > > the code unconditionally available?
> > >
> > > I think removing those specific ifdefs in arp_process()
> > > is the best option, yes.
> >
> > Patch below.
>
> Thanks Adrian. Patch applied to net-2.6.
>
> Do we need this for stable too?
Unless I'm misunderstanding the code we currently wrongly ignore
some ARP packages based on the setting of an unrelated option, so
it seems to be a -stable candidate when it's in Linus' tree.
> Chers,
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-11-26 20:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 19:24 build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Toralf Förster
2007-11-01 21:11 ` Randy Dunlap
2007-11-01 23:32 ` David Brownell
2007-11-01 23:44 ` Adrian Bunk
2007-11-02 18:45 ` David Brownell
2007-11-02 18:57 ` Adrian Bunk
2007-11-02 19:30 ` David Brownell
2007-11-02 19:55 ` Adrian Bunk
2007-11-07 22:34 ` David Brownell
2007-11-07 22:52 ` Adrian Bunk
2007-11-08 2:53 ` David Brownell
2007-11-08 3:23 ` Adrian Bunk
2007-11-08 3:30 ` Adrian Bunk
2007-11-08 16:08 ` Randy Dunlap
2007-11-20 5:26 ` David Miller
2007-11-25 16:30 ` [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess Adrian Bunk
2007-11-26 15:19 ` Herbert Xu
2007-11-26 20:25 ` Adrian Bunk [this message]
2007-11-02 20:05 ` build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Adrian Bunk
2007-11-07 8:20 ` David Miller
2007-11-07 22:15 ` David Brownell
2007-11-01 22:25 ` [2.6 patch] let USB_USBNET always select MII Adrian Bunk
2007-11-01 23:52 ` David Brownell
2007-11-02 15:46 ` [2.6 patch] usbnet.c: check for the right MII variable Adrian Bunk
2007-11-07 22:31 ` David Brownell
2007-11-07 8:10 ` [2.6 patch] let USB_USBNET always select MII David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126202547.GB917@stusta.de \
--to=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.