* [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation
@ 2007-11-01 13:46 Mitsuru Chinen
2007-11-01 15:05 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Mitsuru Chinen @ 2007-11-01 13:46 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, YOSHIFUJI Hideaki, Herbert Xu
As the checksum verification is postponed till user calls recv or poll,
the inrementation of Udp6InErrors counter should be also postponed.
Currently, it is postponed in non-blocking operation case. However it
should be postponed in all case like the IPv4 code.
Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
---
net/ipv6/udp.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index caebad6..8344d8c 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -205,12 +205,11 @@ out:
return err;
csum_copy_err:
+ UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
skb_kill_datagram(sk, skb, flags);
- if (flags & MSG_DONTWAIT) {
- UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
+ if (flags & MSG_DONTWAIT)
return -EAGAIN;
- }
goto try_again;
}
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation
2007-11-01 13:46 [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation Mitsuru Chinen
@ 2007-11-01 15:05 ` Herbert Xu
2007-11-06 5:29 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2007-11-01 15:05 UTC (permalink / raw)
To: Mitsuru Chinen; +Cc: David S. Miller, netdev, YOSHIFUJI Hideaki
On Thu, Nov 01, 2007 at 10:46:38PM +0900, Mitsuru Chinen wrote:
> As the checksum verification is postponed till user calls recv or poll,
> the inrementation of Udp6InErrors counter should be also postponed.
> Currently, it is postponed in non-blocking operation case. However it
> should be postponed in all case like the IPv4 code.
>
> Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Looks good to me. Thanks for catching this!
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation
2007-11-01 15:05 ` Herbert Xu
@ 2007-11-06 5:29 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-11-06 5:29 UTC (permalink / raw)
To: herbert; +Cc: mitch, netdev, yoshfuji
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 1 Nov 2007 23:05:00 +0800
> On Thu, Nov 01, 2007 at 10:46:38PM +0900, Mitsuru Chinen wrote:
> > As the checksum verification is postponed till user calls recv or poll,
> > the inrementation of Udp6InErrors counter should be also postponed.
> > Currently, it is postponed in non-blocking operation case. However it
> > should be postponed in all case like the IPv4 code.
> >
> > Signed-off-by: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
>
> Looks good to me. Thanks for catching this!
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-06 5:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-01 13:46 [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation Mitsuru Chinen
2007-11-01 15:05 ` Herbert Xu
2007-11-06 5:29 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.