All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christoph Egger" <Christoph.Egger@amd.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, "Daniel P.Berrange" <berrange@redhat.com>
Subject: Re: xenfb: portability issue
Date: Fri, 2 Nov 2007 11:54:27 +0200	[thread overview]
Message-ID: <200711021054.27814.Christoph.Egger@amd.com> (raw)
In-Reply-To: <C350A22B.17D28%Keir.Fraser@cl.cam.ac.uk>

On Friday 02 November 2007 10:45:15 Keir Fraser wrote:
> Actually I liked your suggestion better for this particular issue, so I
> checked it in.

I just tested changest 16306 and works fine with me.
Thanks.

Christoph


>  -- Keir
>
> On 2/11/07 09:28, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > I'm testing John Levon's patch.
> >
> > On Friday 02 November 2007 10:19:08 Keir Fraser wrote:
> >> I think John Levon's recent patch might fix this. I'm going to go
> >> through and check in most or all of it I expect.
> >>
> >>  -- Keir
> >>
> >> On 2/11/07 09:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >>> Hi!
> >>>
> >>> Changeset 16250 is not portable. On BSD I get these build errors:
> >>>
> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:19:25: error:
> >>> linux/input.h: No such file or directory
> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c: In
> >>> function 'xenfb_mouse_event':
> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error:
> >>> 'BTN_LEFT' undeclared (first use in this function)
> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: (Each
> >>> undeclared identifier is reported only once
> >>> /root/xen-unstable-netbsd.hg/tools/ioemu/hw/xenfb.c:1038: error: for
> >>> each function it appears in.)



-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

  reply	other threads:[~2007-11-02  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  9:12 xenfb: portability issue Christoph Egger
2007-11-02  9:19 ` Keir Fraser
2007-11-02  9:28   ` Christoph Egger
2007-11-02  9:45     ` Keir Fraser
2007-11-02  9:54       ` Christoph Egger [this message]
2007-11-02  9:48     ` Christoph Egger
2007-11-02  9:23 ` Christoph Egger
2007-11-02 13:38 ` Daniel P. Berrange
2007-11-02 15:34   ` Christoph Egger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711021054.27814.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=berrange@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.