From: Simon Horman <horms@verge.net.au>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
tony.luck@intel.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 2/6] IA64: fix memset size error
Date: Mon, 05 Nov 2007 03:23:19 +0000 [thread overview]
Message-ID: <20071105032319.GA15262@verge.net.au> (raw)
In-Reply-To: <472E7D34.1040509@cn.fujitsu.com>
On Mon, Nov 05, 2007 at 10:17:24AM +0800, Li Zefan wrote:
> The size arguments passing to memset is wrong.
>
> Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
This looks correct to me. Acked.
> ---
> drivers/video/ps3fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> index b3463dd..75836aa 100644
> --- a/drivers/video/ps3fb.c
> +++ b/drivers/video/ps3fb.c
> @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
>
> static int ps3fb_get_vblank(struct fb_vblank *vblank)
> {
> - memset(vblank, 0, sizeof(&vblank));
> + memset(vblank, 0, sizeof(*vblank));
> vblank->flags = FB_VBLANK_HAVE_VSYNC;
> return 0;
> }
> --
> 1.5.3.rc7
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
tony.luck@intel.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 2/6] IA64: fix memset size error
Date: Mon, 5 Nov 2007 12:23:19 +0900 [thread overview]
Message-ID: <20071105032319.GA15262@verge.net.au> (raw)
In-Reply-To: <472E7D34.1040509@cn.fujitsu.com>
On Mon, Nov 05, 2007 at 10:17:24AM +0800, Li Zefan wrote:
> The size arguments passing to memset is wrong.
>
> Signed-off-by Li Zefan <lizf@cn.fujitsu.com>
This looks correct to me. Acked.
> ---
> drivers/video/ps3fb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
> index b3463dd..75836aa 100644
> --- a/drivers/video/ps3fb.c
> +++ b/drivers/video/ps3fb.c
> @@ -727,7 +727,7 @@ static int ps3fb_blank(int blank, struct fb_info *info)
>
> static int ps3fb_get_vblank(struct fb_vblank *vblank)
> {
> - memset(vblank, 0, sizeof(&vblank));
> + memset(vblank, 0, sizeof(*vblank));
> vblank->flags = FB_VBLANK_HAVE_VSYNC;
> return 0;
> }
> --
> 1.5.3.rc7
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
next prev parent reply other threads:[~2007-11-05 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 2:17 [PATCH 2/6] IA64: fix memset size error Li Zefan
2007-11-05 2:17 ` Li Zefan
2007-11-05 2:20 ` Li Zefan
2007-11-05 2:20 ` Li Zefan
2007-11-05 3:23 ` Simon Horman
2007-11-05 3:23 ` Simon Horman
2007-11-05 3:23 ` Simon Horman [this message]
2007-11-05 3:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105032319.GA15262@verge.net.au \
--to=horms@verge.net.au \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.