* [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz
@ 2007-11-04 12:00 Roel Kluin
2007-11-04 22:27 ` Yoichi Yuasa
2007-11-05 11:43 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2007-11-04 12:00 UTC (permalink / raw)
To: linux-mips
iounmap if pci clock is over 33MHz
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/mips/pci/pci-vr41xx.c b/arch/mips/pci/pci-vr41xx.c
index 240df9e..33c4f68 100644
--- a/arch/mips/pci/pci-vr41xx.c
+++ b/arch/mips/pci/pci-vr41xx.c
@@ -154,6 +154,7 @@ static int __init vr41xx_pciu_init(void)
pciu_write(PCICLKSELREG, QUARTER_VTCLOCK);
else {
printk(KERN_ERR "PCI Clock is over 33MHz.\n");
+ iounmap(pciu_base);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz
2007-11-04 12:00 [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz Roel Kluin
@ 2007-11-04 22:27 ` Yoichi Yuasa
2007-11-05 11:43 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Yoichi Yuasa @ 2007-11-04 22:27 UTC (permalink / raw)
To: Roel Kluin; +Cc: yoichi_yuasa, linux-mips
On Sun, 04 Nov 2007 13:00:06 +0100
Roel Kluin <12o3l@tiscali.nl> wrote:
> iounmap if pci clock is over 33MHz
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> ---
> diff --git a/arch/mips/pci/pci-vr41xx.c b/arch/mips/pci/pci-vr41xx.c
> index 240df9e..33c4f68 100644
> --- a/arch/mips/pci/pci-vr41xx.c
> +++ b/arch/mips/pci/pci-vr41xx.c
> @@ -154,6 +154,7 @@ static int __init vr41xx_pciu_init(void)
> pciu_write(PCICLKSELREG, QUARTER_VTCLOCK);
> else {
> printk(KERN_ERR "PCI Clock is over 33MHz.\n");
> + iounmap(pciu_base);
> return -EINVAL;
> }
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz
2007-11-04 12:00 [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz Roel Kluin
2007-11-04 22:27 ` Yoichi Yuasa
@ 2007-11-05 11:43 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2007-11-05 11:43 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-mips
On Sun, Nov 04, 2007 at 01:00:06PM +0100, Roel Kluin wrote:
> iounmap if pci clock is over 33MHz
Applied. Note that this is purely cosmetic; for 64-bit kernels or
anything in the low 512MB of physcial address space ioremap on a 32-bit
kernel ioremap can never fail on MIPS and iounmap is a nop in this case.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-05 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-04 12:00 [PATCH] iounmap if in vr41xx_pciu_init() pci clock is over 33MHz Roel Kluin
2007-11-04 22:27 ` Yoichi Yuasa
2007-11-05 11:43 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.