From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Bryan Wu <bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/4] Blackfin SPI driver: move hard coded pin_req to board file
Date: Mon, 5 Nov 2007 22:03:42 -0800 [thread overview]
Message-ID: <200711052203.42855.david-b@pacbell.net> (raw)
In-Reply-To: <1193971112-7744-4-git-send-email-bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
On Thursday 01 November 2007, Bryan Wu wrote:
> --- a/include/asm-blackfin/bfin5xx_spi.h
> +++ b/include/asm-blackfin/bfin5xx_spi.h
> @@ -152,6 +152,7 @@
> struct bfin5xx_spi_master {
> u16 num_chipselect;
> u8 enable_dma;
> + u16 pin_req[4];
> };
>
> /* spi_board_info.controller_data for SPI slave devices,
I take it there's a patch some where -- outside of this set
of four -- to initialize that new field so drivers will get
valid pin setup data? (That name doesn't sound like it's
platform data, by the way.)
That's going to need to merge in sync with this patch, else
I'd think the resulting kernel won't run ...
- Dave
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Bryan Wu <bryan.wu@analog.com>
Cc: akpm@linux-foundation.org,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Blackfin SPI driver: move hard coded pin_req to board file
Date: Mon, 5 Nov 2007 22:03:42 -0800 [thread overview]
Message-ID: <200711052203.42855.david-b@pacbell.net> (raw)
In-Reply-To: <1193971112-7744-4-git-send-email-bryan.wu@analog.com>
On Thursday 01 November 2007, Bryan Wu wrote:
> --- a/include/asm-blackfin/bfin5xx_spi.h
> +++ b/include/asm-blackfin/bfin5xx_spi.h
> @@ -152,6 +152,7 @@
> struct bfin5xx_spi_master {
> u16 num_chipselect;
> u8 enable_dma;
> + u16 pin_req[4];
> };
>
> /* spi_board_info.controller_data for SPI slave devices,
I take it there's a patch some where -- outside of this set
of four -- to initialize that new field so drivers will get
valid pin setup data? (That name doesn't sound like it's
platform data, by the way.)
That's going to need to merge in sync with this patch, else
I'd think the resulting kernel won't run ...
- Dave
next prev parent reply other threads:[~2007-11-06 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 2:38 [PATCH 0/4] Blackfin SPI driver updates and fixing Bryan Wu
2007-11-02 2:38 ` Bryan Wu
[not found] ` <1193971112-7744-1-git-send-email-bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2007-11-02 2:38 ` [PATCH 1/4] Blackfin SPI driver: use cpu_relax() to replace continue in while busywait Bryan Wu
2007-11-02 2:38 ` Bryan Wu
2007-11-02 2:38 ` [PATCH 2/4] Blackfin SPI driver: use void __iomem * for regs_base Bryan Wu
2007-11-02 2:38 ` Bryan Wu
2007-11-02 2:38 ` [PATCH 3/4] Blackfin SPI driver: move hard coded pin_req to board file Bryan Wu
2007-11-02 2:38 ` Bryan Wu
[not found] ` <1193971112-7744-4-git-send-email-bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2007-11-06 6:03 ` David Brownell [this message]
2007-11-06 6:03 ` David Brownell
[not found] ` <200711052203.42855.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-11-06 6:46 ` Bryan Wu
2007-11-06 6:46 ` Bryan Wu
2007-11-02 2:38 ` [PATCH 4/4] Blackfin SPI driver: reconfigure speed_hz and bits_per_word in each spi transfer Bryan Wu
2007-11-02 2:38 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711052203.42855.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bryan.wu-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.