From: Alexander Viro <aviro@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <aviro@redhat.com>,
Steve Dickson <SteveD@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
nfs@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [PATCH] NFS: Stop sillyname renames and unmounts from racing
Date: Tue, 6 Nov 2007 00:15:32 -0500 [thread overview]
Message-ID: <20071106051532.GA5397@devserv.devel.redhat.com> (raw)
In-Reply-To: <20071105210636.2fc72e14.akpm@linux-foundation.org>
On Mon, Nov 05, 2007 at 09:06:36PM -0800, Andrew Morton wrote:
> > Any objections to exporting the inode_lock spin lock?
> > If so, how should modules _safely_ access the s_inode list?
> That's going to make hch unhappy.
That's going to make me just as unhappy, especially since it's pointless;
instead of the entire sorry mess we should just bump sb->s_active to pin
the superblock down (we know that it's active at that point, so it's just
an atomic_inc(); no games with locking, etc., are needed) and call
deactivate_super() on the way out. And deactivate_super() is exported
already.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Viro <aviro@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Steve Dickson <SteveD@redhat.com>,
Alexander Viro <aviro@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
nfs@lists.sourceforge.net,
"J. Bruce Fields" <bfields@fieldses.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: [PATCH] NFS: Stop sillyname renames and unmounts from racing
Date: Tue, 6 Nov 2007 00:15:32 -0500 [thread overview]
Message-ID: <20071106051532.GA5397@devserv.devel.redhat.com> (raw)
In-Reply-To: <20071105210636.2fc72e14.akpm@linux-foundation.org>
On Mon, Nov 05, 2007 at 09:06:36PM -0800, Andrew Morton wrote:
> > Any objections to exporting the inode_lock spin lock?
> > If so, how should modules _safely_ access the s_inode list?
> That's going to make hch unhappy.
That's going to make me just as unhappy, especially since it's pointless;
instead of the entire sorry mess we should just bump sb->s_active to pin
the superblock down (we know that it's active at that point, so it's just
an atomic_inc(); no games with locking, etc., are needed) and call
deactivate_super() on the way out. And deactivate_super() is exported
already.
next prev parent reply other threads:[~2007-11-06 5:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 11:09 [PATCH] NFS: Stop sillyname renames and unmounts from racing Steve Dickson
2007-11-06 5:06 ` Andrew Morton
2007-11-06 5:06 ` Andrew Morton
2007-11-06 5:15 ` Alexander Viro [this message]
2007-11-06 5:15 ` Alexander Viro
2007-11-08 9:05 ` Steve Dickson
2007-11-08 9:05 ` Steve Dickson
2007-11-06 8:24 ` Benny Halevy
2007-11-06 8:24 ` Benny Halevy
2007-11-06 8:50 ` Alexander Viro
-- strict thread matches above, loose matches on Subject: below --
2007-10-31 16:40 Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106051532.GA5397@devserv.devel.redhat.com \
--to=aviro@redhat.com \
--cc=SteveD@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.