a list of non-existent but included include/linux header files

a list of non-existent but included include/linux header files

[Robert P. J. Day]

  this list is short enough that i'll just post it here -- attempts to
include header files under include/linux when those header files
simply don't exist.  obviously, there might be false positives for one
reason or another.  (the only manual culling i did of the list was to
remove inclusions of autoconf.h and utsrelease.h -- i assumed those
weren't an issue for anyone.)

=== Missing: include/linux/blk.h ===
arch/frv/kernel/setup.c:#include <linux/blk.h>
=== Missing: include/linux/cachefs.h ===
fs/afs/cache.h:#include <linux/cachefs.h>
=== Missing: include/linux/compile.h ===
arch/x86/boot/version.c:#include <linux/compile.h>
init/version.c:#include <linux/compile.h>
=== Missing: include/linux/debugger.h ===
arch/blackfin/kernel/kgdb.c:#include <linux/debugger.h>
=== Missing: include/linux/ioctl32.h ===
drivers/video/sis/sis.h:#include <linux/ioctl32.h>
=== Missing: include/linux/kdb.h ===
drivers/acpi/osl.c:#include <linux/kdb.h>
=== Missing: include/linux/kgdb.h ===
arch/blackfin/kernel/kgdb.c:#include <linux/kgdb.h>
arch/blackfin/mach-common/ints-priority-dc.c:#include <linux/kgdb.h>
arch/blackfin/mach-common/ints-priority-sc.c:#include <linux/kgdb.h>
drivers/serial/bfin_5xx.c:#include <linux/kgdb.h>
=== Missing: include/linux/l3/l3.h ===
sound/arm/sa11xx-uda1341.c:#include <linux/l3/l3.h>
sound/i2c/l3/uda1341.c:#include <linux/l3/l3.h>
=== Missing: include/linux/mtd/mtdram.h ===
arch/cris/arch-v32/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>
arch/cris/arch-v10/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>
=== Missing: include/linux/pkthook.h ===
arch/ppc/8xx_io/fec.c:#include <linux/pkthook.h>
=== Missing: include/linux/segment.h ===
arch/sparc/kernel/sys_sunos.c:#include <linux/segment.h>
=== Missing: include/linux/serial_ip3106.h ===
arch/mips/philips/pnx8550/common/gdb_hook.c:#include <linux/serial_ip3106.h>
=== Missing: include/linux/spi/tsc2102.h ===
arch/arm/mach-omap1/board-palmte.c:#include <linux/spi/tsc2102.h>
=== Missing: include/linux/squashfs_fs.h ===
arch/mips/pmc-sierra/msp71xx/msp_prom.c:#include <linux/squashfs_fs.h>
=== Missing: include/linux/tqueue.h ===
drivers/pcmcia/au1000_xxs1500.c:#include <linux/tqueue.h>
drivers/pcmcia/au1000_pb1x00.c:#include <linux/tqueue.h>
=== Missing: include/linux/usb_gadget.h ===
drivers/i2c/chips/isp1301_omap.c:#include <linux/usb_gadget.h>
=== Missing: include/linux/usb_isp1362.h ===
arch/blackfin/mach-bf533/boards/ezkit.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf533/boards/stamp.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf533/boards/cm_bf533.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf533/boards/H8606.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf537/boards/pnav10.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf537/boards/generic_board.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf537/boards/cm_bf537.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf537/boards/stamp.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf527/boards/ezkit.c:#include <linux/usb_isp1362.h>
arch/blackfin/mach-bf561/boards/cm_bf561.c:#include <linux/usb_isp1362.h>
=== Missing: include/linux/usb/musb.h ===
arch/blackfin/mach-bf548/boards/ezkit.c:#include <linux/usb/musb.h>
arch/arm/mach-omap2/usb-tusb6010.c:#include <linux/usb/musb.h>
=== Missing: include/linux/usb_sl811.h ===
arch/blackfin/mach-bf527/boards/ezkit.c:#include <linux/usb_sl811.h>


-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

Re: a list of non-existent but included include/linux header files

[Mike Frysinger]

On 11/5/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>   this list is short enough that i'll just post it here -- attempts to
> include header files under include/linux when those header files
> simply don't exist.  obviously, there might be false positives for one
> reason or another.

obviously the kgdb ones can be ignored

> (the only manual culling i did of the list was to
> remove inclusions of autoconf.h and utsrelease.h -- i assumed those
> weren't an issue for anyone.)

should do the opposite ... nobody should be including linux/autoconf.h

as for the Blackfin ones, the answer is the same last time you ask ...
the includes are for drivers we havent pushed to mainline yet
-mike

Re: a list of non-existent but included include/linux header files

[Robert P. J. Day]

On Mon, 5 Nov 2007, Mike Frysinger wrote:

> > (the only manual culling i did of the list was to remove
> > inclusions of autoconf.h and utsrelease.h -- i assumed those
> > weren't an issue for anyone.)
>
> should do the opposite ... nobody should be including
> linux/autoconf.h

ah, good point:

$ grep -r "<linux/autoconf.h>" *
arch/blackfin/mm/blackfin_sram.c:#include <linux/autoconf.h>
arch/blackfin/mach-common/interrupt.S:#include <linux/autoconf.h>
arch/mips/au1000/common/gpio.c:#include <linux/autoconf.h>
arch/m68knommu/lib/memcpy.c:#include <linux/autoconf.h>
drivers/char/mxser_new.c:#include <linux/autoconf.h>
drivers/char/mxser.c:#include <linux/autoconf.h>
drivers/ide/pci/delkin_cb.c:#include <linux/autoconf.h>
drivers/firmware/dmi-id.c:#include <linux/autoconf.h>
drivers/spi/spi.c:#include <linux/autoconf.h>
drivers/misc/fujitsu-laptop.c:#include <linux/autoconf.h>
drivers/misc/asus-laptop.c:#include <linux/autoconf.h>
drivers/misc/msi-laptop.c:#include <linux/autoconf.h>

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

Re: a list of non-existent but included include/linux header files

[Mike Frysinger]

On 11/5/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> arch/blackfin/mm/blackfin_sram.c:#include <linux/autoconf.h>
> arch/blackfin/mach-common/interrupt.S:#include <linux/autoconf.h>

i seem to recall these already getting fixed, but just in case, ive
queued up patches for these

cheers
-mike

Re: a list of non-existent but included include/linux header files

[Adrian Bunk]

On Mon, Nov 05, 2007 at 11:31:39PM -0500, Robert P. J. Day wrote:
> 
>   this list is short enough that i'll just post it here -- attempts to
> include header files under include/linux when those header files
> simply don't exist.  obviously, there might be false positives for one
> reason or another.  (the only manual culling i did of the list was to
> remove inclusions of autoconf.h and utsrelease.h -- i assumed those
> weren't an issue for anyone.)
>...
> === Missing: include/linux/compile.h ===
> arch/x86/boot/version.c:#include <linux/compile.h>
> init/version.c:#include <linux/compile.h>
>...

That's a generated header.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: a list of non-existent but included include/linux header files

[Jesper Nilsson]

On Mon, Nov 05, 2007 at 11:31:39PM -0500, Robert P. J. Day wrote:
> === Missing: include/linux/mtd/mtdram.h ===
> arch/cris/arch-v32/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>
> arch/cris/arch-v10/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>

The above headerfile should be in the queue for inclusion.

> Robert P. J. Day

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- jesper.nilsson@axis.com

Re: a list of non-existent but included include/linux header files

[Jörn Engel]

On Tue, 6 November 2007 11:56:19 +0100, Jesper Nilsson wrote:
> On Mon, Nov 05, 2007 at 11:31:39PM -0500, Robert P. J. Day wrote:
> > === Missing: include/linux/mtd/mtdram.h ===
> > arch/cris/arch-v32/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>
> > arch/cris/arch-v10/drivers/axisflashmap.c:#include <linux/mtd/mtdram.h>
> 
> The above headerfile should be in the queue for inclusion.

It is.  I was already wondering what might be using it.

Jörn

-- 
To my face you have the audacity to advise me to become a thief - the worst
kind of thief that is conceivable, a thief of spiritual things, a thief of
ideas! It is insufferable, intolerable!
-- M. Binet in Scarabouche