All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hans-Jürgen Koch" <hjk@linutronix.de>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Mark Lord <lkml@rtr.ca>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] r8169 fix regression on ASUS motherboards (updated)
Date: Thu, 8 Nov 2007 09:49:11 +0100	[thread overview]
Message-ID: <20071108094911.241bab27@dilbert.local> (raw)
In-Reply-To: <20071108002112.GD15367@electric-eye.fr.zoreil.com>

Am Thu, 8 Nov 2007 01:21:12 +0100
schrieb Francois Romieu <romieu@fr.zoreil.com>:

> Mark Lord <lkml@rtr.ca> :
> [...]
> > I've now received a couple of private emails from people reporting
> > full success with this patch.
> 
> Ok, I have pushed the patch below for Jeff to pull at korg.
> 
> >From 1dd7681bc2ff171341ea5cae957f8ecb5c0c102e Mon Sep 17 00:00:00
> >2001
> From: Mark Lord <mlord@pobox.com>
> Date: Thu, 8 Nov 2007 01:03:04 +0100
> Subject: [PATCH] r8169: revert
> 7da97ec96a0934319c7fbedd3d38baf533e20640 (partly)
> 
> Various symptoms depending on the .config options:
> - the card stops working after some (short) time
> - the card does not work at all
> - the card disappears (nothing in lspci/dmesg)
> 
> A real power-off is needed to recover the card.

This patch fixes the same problem on my MSI board.

> 
> Signed-off-by: Mark Lord <mlord@pobox.com>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Acked-by: Hans J. Koch <hjk@linutronix.de>

> ---
>  drivers/net/r8169.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 9dbab3f..a37cf82 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -1328,6 +1328,7 @@ static void rtl_hw_phy_config(struct net_device
> *dev) break;
>  	case RTL_GIGA_MAC_VER_11:
>  	case RTL_GIGA_MAC_VER_12:
> +		break;
>  	case RTL_GIGA_MAC_VER_17:
>  		rtl8168b_hw_phy_config(ioaddr);
>  		break;

  reply	other threads:[~2007-11-08  8:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 16:07 r8169: NFG in 2.6.24-rc2 Mark Lord
2007-11-07 17:11 ` Mark Lord
2007-11-07 18:02 ` [PATCH] r8169 fix regression on ASUS motherboards Mark Lord
2007-11-07 22:04   ` Francois Romieu
2007-11-07 22:21     ` Mark Lord
2007-11-07 22:25       ` [PATCH] r8169 fix regression on ASUS motherboards (updated) Mark Lord
2007-11-07 22:48         ` Francois Romieu
2007-11-07 23:23           ` Mark Lord
2007-11-07 23:20         ` Mark Lord
2007-11-08  0:21           ` Francois Romieu
2007-11-08  8:49             ` Hans-Jürgen Koch [this message]
2007-11-08 14:16             ` [PATCH] r8169 fix regression on ASUS motherboards (updated again) Mark Lord
2007-11-08 21:05               ` Francois Romieu
2007-11-07 21:03 ` r8169: NFG in 2.6.24-rc2 cecco
2007-11-07 22:08   ` Francois Romieu
2007-11-08  7:52 ` Hans-Jürgen Koch
2007-11-08  8:44   ` Hans-Jürgen Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071108094911.241bab27@dilbert.local \
    --to=hjk@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=romieu@fr.zoreil.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.