All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] r8169 fix regression on ASUS motherboards (updated)
Date: Wed, 07 Nov 2007 18:23:42 -0500	[thread overview]
Message-ID: <473248FE.2020907@rtr.ca> (raw)
In-Reply-To: <20071107224808.GC15367@electric-eye.fr.zoreil.com>

Francois Romieu wrote:
> Mark Lord <lkml@rtr.ca> :
>> Mark Lord wrote:
>>> Francois Romieu wrote:
>>> ..
>>>> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
>>>> too, namely XID = 0x38000000.
>> ..
>>
>> Here is the updated patch for both VER_11 and VER_12.
>> Let's get this in, as the driver has been broken for weeks now.
> 
> I have not been waiting for you and I am not interested in your
> controversy.
> 
> I'll find the offending commit and revert it. It is that simple.
..

I think the rest of the commit was fine -- there seems to be some
nice cleanups there to make it easier to maintain.

Just the new register writes (rtl8168b_hw_phy_config()) are mucking things up.
Prevent those from happening, and all is well.

Cheers


  reply	other threads:[~2007-11-07 23:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 16:07 r8169: NFG in 2.6.24-rc2 Mark Lord
2007-11-07 17:11 ` Mark Lord
2007-11-07 18:02 ` [PATCH] r8169 fix regression on ASUS motherboards Mark Lord
2007-11-07 22:04   ` Francois Romieu
2007-11-07 22:21     ` Mark Lord
2007-11-07 22:25       ` [PATCH] r8169 fix regression on ASUS motherboards (updated) Mark Lord
2007-11-07 22:48         ` Francois Romieu
2007-11-07 23:23           ` Mark Lord [this message]
2007-11-07 23:20         ` Mark Lord
2007-11-08  0:21           ` Francois Romieu
2007-11-08  8:49             ` Hans-Jürgen Koch
2007-11-08 14:16             ` [PATCH] r8169 fix regression on ASUS motherboards (updated again) Mark Lord
2007-11-08 21:05               ` Francois Romieu
2007-11-07 21:03 ` r8169: NFG in 2.6.24-rc2 cecco
2007-11-07 22:08   ` Francois Romieu
2007-11-08  7:52 ` Hans-Jürgen Koch
2007-11-08  8:44   ` Hans-Jürgen Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473248FE.2020907@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.