From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org, Jeff Garzik <jeff@garzik.org>
Subject: [PATCH] Fix infinite loop on dev_mc_unsync()
Date: Fri, 9 Nov 2007 10:11:35 -0500 [thread overview]
Message-ID: <20071109151135.GA12982@pogo> (raw)
While reviewing net/core/dev_mcast.c I found what I think is an
infinite loop on dev_mc_unsync(). This fixes it. We make use of
this guy on mac80211 in ieee80211_stop(). This is untested.
Signed-off-by: Luis R. Rodriguez <mcgrof@winlab.rutgers.edu>
diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c
index 15241cf..5373c03 100644
--- a/net/core/dev_mcast.c
+++ b/net/core/dev_mcast.c
@@ -168,8 +168,10 @@ void dev_mc_unsync(struct net_device *to, struct net_device *from)
da = from->mc_list;
while (da != NULL) {
next = da->next;
- if (!da->da_synced)
+ if (!da->da_synced) {
+ da = next;
continue;
+ }
__dev_addr_delete(&to->mc_list, &to->mc_count,
da->da_addr, da->da_addrlen, 0);
da->da_synced = 0;
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Garzik <jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
Subject: [PATCH] Fix infinite loop on dev_mc_unsync()
Date: Fri, 9 Nov 2007 10:11:35 -0500 [thread overview]
Message-ID: <20071109151135.GA12982@pogo> (raw)
While reviewing net/core/dev_mcast.c I found what I think is an
infinite loop on dev_mc_unsync(). This fixes it. We make use of
this guy on mac80211 in ieee80211_stop(). This is untested.
Signed-off-by: Luis R. Rodriguez <mcgrof-NvJAj8134tRxEa0u/P/EHDe48wsgrGvP@public.gmane.org>
diff --git a/net/core/dev_mcast.c b/net/core/dev_mcast.c
index 15241cf..5373c03 100644
--- a/net/core/dev_mcast.c
+++ b/net/core/dev_mcast.c
@@ -168,8 +168,10 @@ void dev_mc_unsync(struct net_device *to, struct net_device *from)
da = from->mc_list;
while (da != NULL) {
next = da->next;
- if (!da->da_synced)
+ if (!da->da_synced) {
+ da = next;
continue;
+ }
__dev_addr_delete(&to->mc_list, &to->mc_count,
da->da_addr, da->da_addrlen, 0);
da->da_synced = 0;
next reply other threads:[~2007-11-09 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 15:11 Luis R. Rodriguez [this message]
2007-11-09 15:11 ` [PATCH] Fix infinite loop on dev_mc_unsync() Luis R. Rodriguez
2007-11-09 18:51 ` Luis R. Rodriguez
2007-11-09 18:51 ` Luis R. Rodriguez
2007-11-09 19:07 ` Joe Perches
2007-11-09 19:07 ` Joe Perches
2007-11-09 19:21 ` Luis R. Rodriguez
2007-11-09 19:21 ` Luis R. Rodriguez
2007-11-09 23:12 ` Patrick McHardy
2007-11-10 0:08 ` Joe Perches
2007-11-10 0:08 ` Joe Perches
2007-11-10 0:13 ` Patrick McHardy
2007-11-10 0:13 ` Patrick McHardy
2007-11-11 5:34 ` David Miller
2007-11-11 5:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109151135.GA12982@pogo \
--to=mcgrof@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.