From: Andi Kleen <ak@suse.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: Some interesting observations when trying to optimize vmstat handling
Date: Fri, 9 Nov 2007 16:56:26 +0100 [thread overview]
Message-ID: <200711091656.26908.ak@suse.de> (raw)
In-Reply-To: <4733A7A5.9000900@goop.org>
On Friday 09 November 2007 01:19, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > The only problem is that there might be some code who relies on
> > restore_flags() restoring other flags that IF, but at least for
> > interrupts and local_irq_save/restore it should be fine to change.
>
> I don't think so. We don't bother to save/restore the other flags in
> Xen paravirt and it doesn't seem to cause a problem. The semantics
> really are specific to the state of the interrupt flag.
Yes i checked the code and only case I found is actually save_flags, not
restore_flags
(and that particular case is even unnecessary)
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: Some interesting observations when trying to optimize vmstat handling
Date: Fri, 9 Nov 2007 16:56:26 +0100 [thread overview]
Message-ID: <200711091656.26908.ak@suse.de> (raw)
In-Reply-To: <4733A7A5.9000900@goop.org>
On Friday 09 November 2007 01:19, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > The only problem is that there might be some code who relies on
> > restore_flags() restoring other flags that IF, but at least for
> > interrupts and local_irq_save/restore it should be fine to change.
>
> I don't think so. We don't bother to save/restore the other flags in
> Xen paravirt and it doesn't seem to cause a problem. The semantics
> really are specific to the state of the interrupt flag.
Yes i checked the code and only case I found is actually save_flags, not
restore_flags
(and that particular case is even unnecessary)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-09 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 19:58 Some interesting observations when trying to optimize vmstat handling Christoph Lameter
2007-11-08 23:07 ` Andi Kleen
2007-11-08 23:07 ` Andi Kleen
2007-11-08 23:25 ` Christoph Lameter
2007-11-08 23:25 ` Christoph Lameter
2007-11-09 0:19 ` Jeremy Fitzhardinge
2007-11-09 0:19 ` Jeremy Fitzhardinge
2007-11-09 15:56 ` Andi Kleen [this message]
2007-11-09 15:56 ` Andi Kleen
2007-11-08 23:24 ` David Miller
2007-11-08 23:24 ` David Miller, Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711091656.26908.ak@suse.de \
--to=ak@suse.de \
--cc=clameter@sgi.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.