From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Drake <dsd@gentoo.org>,
rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
kay.sievers@vrfy.org, linux-hotplug-devel@lists.sourceforge.net,
oneukum@suse.de
Subject: Re: [PATCH] create /sys/.../power when CONFIG_PM is set
Date: Fri, 09 Nov 2007 21:32:23 +0000 [thread overview]
Message-ID: <20071109213223.GA28276@kroah.com> (raw)
In-Reply-To: <20071109130555.5304d49a.akpm@linux-foundation.org>
On Fri, Nov 09, 2007 at 01:05:55PM -0800, Andrew Morton wrote:
> On Wed, 7 Nov 2007 10:10:43 +0000 (GMT)
> Daniel Drake <dsd@gentoo.org> wrote:
>
> > The CONFIG_SUSPEND changes in 2.6.23 caused a regression under certain
> > configuration conditions (SUSPEND=n, USB_AUTOSUSPEND=y) where all USB device
> > attributes in sysfs (idVendor, idProduct, ...) silently disappeared, causing
> > udev breakage and more.
> >
> > The cause of this is that the /sys/.../power subdirectory is now only created
> > when CONFIG_PM_SLEEP is set, however, it should be created whenever CONFIG_PM
> > is set to handle the above situation. The following patch fixes the
> > regression.
> >
>
> Your patch is for 2.6.24-rc2 and 2.6.23, afacit. It needed some work to
> apply on Greg's tree because the new pm_sleep_lock() and pm_sleep_unlock()
> went and copied the same bug as you've fixed here.
>
> I guess the right thing to do is to apply your patch as-is to 2.6.24-rcX
> and to 2.6.23.x. I can't really do that because doing so would wreck my
> copy of Greg's tree.
>
>
> So I'll run with the below (I think it's right) and will let Greg sort it
> out ;)
Yeah, I'll sort it all out :)
thanks,
greg k-h
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Drake <dsd@gentoo.org>,
rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
kay.sievers@vrfy.org, linux-hotplug-devel@lists.sourceforge.net,
oneukum@suse.de
Subject: Re: [PATCH] create /sys/.../power when CONFIG_PM is set
Date: Fri, 9 Nov 2007 13:32:23 -0800 [thread overview]
Message-ID: <20071109213223.GA28276@kroah.com> (raw)
In-Reply-To: <20071109130555.5304d49a.akpm@linux-foundation.org>
On Fri, Nov 09, 2007 at 01:05:55PM -0800, Andrew Morton wrote:
> On Wed, 7 Nov 2007 10:10:43 +0000 (GMT)
> Daniel Drake <dsd@gentoo.org> wrote:
>
> > The CONFIG_SUSPEND changes in 2.6.23 caused a regression under certain
> > configuration conditions (SUSPEND=n, USB_AUTOSUSPEND=y) where all USB device
> > attributes in sysfs (idVendor, idProduct, ...) silently disappeared, causing
> > udev breakage and more.
> >
> > The cause of this is that the /sys/.../power subdirectory is now only created
> > when CONFIG_PM_SLEEP is set, however, it should be created whenever CONFIG_PM
> > is set to handle the above situation. The following patch fixes the
> > regression.
> >
>
> Your patch is for 2.6.24-rc2 and 2.6.23, afacit. It needed some work to
> apply on Greg's tree because the new pm_sleep_lock() and pm_sleep_unlock()
> went and copied the same bug as you've fixed here.
>
> I guess the right thing to do is to apply your patch as-is to 2.6.24-rcX
> and to 2.6.23.x. I can't really do that because doing so would wreck my
> copy of Greg's tree.
>
>
> So I'll run with the below (I think it's right) and will let Greg sort it
> out ;)
Yeah, I'll sort it all out :)
thanks,
greg k-h
next prev parent reply other threads:[~2007-11-09 21:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 10:10 [PATCH] create /sys/.../power when CONFIG_PM is set Daniel Drake
2007-11-07 10:10 ` Daniel Drake
2007-11-07 16:45 ` Alan Stern
2007-11-07 16:45 ` Alan Stern
2007-11-07 16:45 ` Alan Stern
2007-11-07 22:24 ` Rafael J. Wysocki
2007-11-07 22:24 ` Rafael J. Wysocki
2007-11-07 22:24 ` Rafael J. Wysocki
2007-11-08 0:27 ` Greg KH
2007-11-08 0:27 ` Greg KH
2007-11-08 0:27 ` Greg KH
2007-11-09 21:05 ` Andrew Morton
2007-11-09 21:05 ` Andrew Morton
2007-11-09 21:32 ` Greg KH
2007-11-09 21:32 ` Greg KH [this message]
2007-11-09 21:32 ` Greg KH
2007-11-09 21:05 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2007-11-07 10:10 Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109213223.GA28276@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=dsd@gentoo.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.