All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE)
Date: Sat, 10 Nov 2007 22:24:21 +0100	[thread overview]
Message-ID: <20071110212421.GI15633@thorin> (raw)
In-Reply-To: <4736009D.3010502@t-online.de>

On Sat, Nov 10, 2007 at 08:03:57PM +0100, Christian Franke wrote:
> 
> This patch fixes this by ignoring the difference. It actually works to 
> load modules compiled on Linux by a kernel compiled on Cygwin (with 
> underscores) and vice versa.
>
> [...]
> +
> +  /* Ignore leading underscore used for C symbols.
> +     Done at runtime to allow loading modules compiled on other OS.  */
> +  if (*name == '_')
> +    name++;

Is that something we really want?  We never made any efforts at maintaining
ABI between kernel and modules, or in allowing this kind of combinations.  If
we go this path, it can mean more work later (e.g. support for building kernel
and modules with different versions of GCC, etc).

Could you give an example of a situation in which this would be useful?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2007-11-10 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 19:03 [PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE) Christian Franke
2007-11-10 21:24 ` Robert Millan [this message]
2007-11-11 18:24   ` Christian Franke
2007-11-18  6:18     ` Robert Millan
2007-11-18 20:52       ` Christian Franke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071110212421.GI15633@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.