Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

[Erez Zadok]

Andrew,

I'm getting minor warnings when applying two patches from
<http://userweb.kernel.org/~akpm/mmotm/>

It's probably not serious but I wonder if checkpatch catches this.

Applying patch..git-net.patch
Warning: commit message does not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.

Applying patch..mnt_unbindable-fix.patch
Warning: commit message does not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.

Erez.

Re: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

[Andy Whitcroft]

On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote:
> Andrew,
> 
> I'm getting minor warnings when applying two patches from
> <http://userweb.kernel.org/~akpm/mmotm/>
> 
> It's probably not serious but I wonder if checkpatch catches this.
> 
> Applying patch..git-net.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.
> 
> Applying patch..mnt_unbindable-fix.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.

We do have checks for UTF-8.  The commit message problems are usually real
names in Signed-off-by:s being "complex" and being in their email locale
not UTF-8.  It is a problem area for sure as people want their email to
look right in their email to the list, and yet they need it in UTF-8 for git.

Yeah it looks like we pick it up ok, the message could do with a little
love:

    apw@pinky$ ~/git/checkpatch/checkpatch.pl -q --no-tree ./git-net.patch
    ERROR: Invalid UTF-8
    #229:
	This is based on a patch by Vicenç Beltran Querol.

    ERROR: Invalid UTF-8
    #398:
	by Toralf Förster:

    ERROR: Invalid UTF-8
    #773:
	Signed-off-by: Lutz Preßler <Lutz.Pressler@SerNet.DE>

-apw