All of lore.kernel.org
 help / color / mirror / Atom feed
* - libata-dont-fail-ata-device-revalidation-for-bad-_gtf-methods.patch removed from -mm tree
@ 2007-11-13  4:07 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-11-13  4:07 UTC (permalink / raw)
  To: mjg59, roppedisano, mm-commits


The patch titled
     libata: don't fail ata device revalidation for bad _GTF methods
has been removed from the -mm tree.  Its filename was
     libata-dont-fail-ata-device-revalidation-for-bad-_gtf-methods.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
Subject: libata: don't fail ata device revalidation for bad _GTF methods
From: Matthew Garrett <mjg59@srcf.ucam.org>

Experience suggests that the _GTF method may be bad.  We currently fail
device revalidation in that case, which seems excessive.

Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
Tested-by: Roberto Oppedisano <roppedisano@infracomspa.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/ata/libata-acpi.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff -puN drivers/ata/libata-acpi.c~libata-dont-fail-ata-device-revalidation-for-bad-_gtf-methods drivers/ata/libata-acpi.c
--- a/drivers/ata/libata-acpi.c~libata-dont-fail-ata-device-revalidation-for-bad-_gtf-methods
+++ a/drivers/ata/libata-acpi.c
@@ -312,7 +312,7 @@ EXPORT_SYMBOL_GPL(ata_acpi_stm);
  *
  * RETURNS:
  * Number of taskfiles on success, 0 if _GTF doesn't exist or doesn't
- * contain valid data.  -errno on other errors.
+ * contain valid data.
  */
 static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf,
 			   void **ptr_to_free)
@@ -339,7 +339,6 @@ static int ata_dev_get_GTF(struct ata_de
 			ata_dev_printk(dev, KERN_WARNING,
 				       "_GTF evaluation failed (AE 0x%x)\n",
 				       status);
-			rc = -EIO;
 		}
 		goto out_free;
 	}
@@ -359,7 +358,6 @@ static int ata_dev_get_GTF(struct ata_de
 		ata_dev_printk(dev, KERN_WARNING,
 			       "_GTF unexpected object type 0x%x\n",
 			       out_obj->type);
-		rc = -EINVAL;
 		goto out_free;
 	}
 
@@ -367,7 +365,6 @@ static int ata_dev_get_GTF(struct ata_de
 		ata_dev_printk(dev, KERN_WARNING,
 			       "unexpected _GTF length (%d)\n",
 			       out_obj->buffer.length);
-		rc = -EINVAL;
 		goto out_free;
 	}
 
@@ -511,10 +508,7 @@ static int ata_acpi_exec_tfs(struct ata_
 	int gtf_count, i, rc;
 
 	/* get taskfiles */
-	rc = ata_dev_get_GTF(dev, &gtf, &ptr_to_free);
-	if (rc < 0)
-		return rc;
-	gtf_count = rc;
+	gtf_count = ata_dev_get_GTF(dev, &gtf, &ptr_to_free);
 
 	/* execute them */
 	for (i = 0, rc = 0; i < gtf_count; i++) {
_

Patches currently in -mm which might be from mjg59@srcf.ucam.org are

origin.patch
working-3d-dri-intel-agpko-resume-for-i815-chip.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-11-13  4:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-13  4:07 - libata-dont-fail-ata-device-revalidation-for-bad-_gtf-methods.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.