From: David Chinner <dgc@sgi.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [xfs-masters] Re: [PATCH] fs/xfs: remove duplicated defines
Date: Wed, 14 Nov 2007 05:41:00 +0000 [thread overview]
Message-ID: <20071114054100.GJ995458@sgi.com> (raw)
In-Reply-To: <20071111134351.106efb98@lucky.kitzblitz>
On Wed, Nov 14, 2007 at 01:46:52PM +1100, Timothy Shimmin wrote:
> David Chinner wrote:
> > Just replace them with (val & PAGE_CACHE_MASK)
^^^^^^^^^^^^^^^
......
> --- a/fs/xfs/linux-2.6/xfs_lrw.c 2007-11-14 13:02:46.000000000 +1100
> +++ b/fs/xfs/linux-2.6/xfs_lrw.c 2007-11-14 12:36:59.920080014 +1100
> @@ -254,9 +254,8 @@ xfs_read(
>
> if (unlikely(ioflags & IO_ISDIRECT)) {
> if (VN_CACHED(vp))
> - ret = xfs_flushinval_pages(ip,
> - ctooff(offtoct(*offset)),
> - -1, FI_REMAPF_LOCKED);
> + ret = xfs_flushinval_pages(ip, (*offset & PAGE_MASK),
^^^^^^^^^
s/PAGE_MASK/PAGE_CACHE_MASK/g
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-11-14 5:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 12:43 [PATCH] fs/xfs: remove duplicated defines Nicolas Kaiser
2007-11-11 23:57 ` [xfs-masters] " Eric Sandeen
2007-11-11 23:57 ` Eric Sandeen
2007-11-12 0:09 ` Timothy Shimmin
2007-11-12 0:09 ` Timothy Shimmin
2007-11-12 0:28 ` Timothy Shimmin
2007-11-12 0:33 ` [xfs-masters] " Timothy Shimmin
2007-11-12 2:04 ` David Chinner
2007-11-13 5:35 ` Timothy Shimmin
2007-11-13 21:30 ` David Chinner
2007-11-14 2:46 ` Timothy Shimmin
2007-11-14 5:41 ` David Chinner [this message]
2007-11-15 0:54 ` Timothy Shimmin
2007-11-15 6:27 ` David Chinner
2007-11-16 5:34 ` [PATCH] remove BPCSHIFT and NB?P? macros - was fs/xfs: remove duplicated Timothy Shimmin
2007-11-16 6:15 ` [xfs-masters] [PATCH] remove BPCSHIFT and NB?P? macros - was Lachlan McIlroy
2007-11-16 6:15 ` [xfs-masters] [PATCH] remove BPCSHIFT and NB?P? macros - was fs/xfs: remove duplicated defines Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114054100.GJ995458@sgi.com \
--to=dgc@sgi.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.