* [PATCH][TOOLS] ioemu: build fix
@ 2007-11-15 14:00 Christoph Egger
2007-11-16 16:41 ` Keir Fraser
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Egger @ 2007-11-15 14:00 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
Hi!
Attached patch fixes the following linking error which I am seeing on BSD:
ossaudio.o: In function `oss_open':
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to
`_oss_ioctl'
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to
`_oss_ioctl'
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to
`_oss_ioctl'
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to
`_oss_ioctl'
/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to
`_oss_ioctl'
ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
undefined references to `_oss_ioctl' follow
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
[-- Attachment #2: tools_ioemu.diff --]
[-- Type: text/plain, Size: 330 bytes --]
diff -r ba69fe2dce91 tools/ioemu/Makefile.target
--- a/tools/ioemu/Makefile.target Tue Nov 13 20:13:50 2007 +0000
+++ b/tools/ioemu/Makefile.target Thu Nov 15 17:01:41 2007 +0100
@@ -365,6 +365,7 @@ endif
endif
ifdef CONFIG_OSS
AUDIODRV += ossaudio.o
+LIBS += -lossaudio
endif
ifdef CONFIG_COREAUDIO
AUDIODRV += coreaudio.o
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TOOLS] ioemu: build fix
2007-11-15 14:00 [PATCH][TOOLS] ioemu: build fix Christoph Egger
@ 2007-11-16 16:41 ` Keir Fraser
2007-11-16 17:22 ` Christoph Egger
0 siblings, 1 reply; 6+ messages in thread
From: Keir Fraser @ 2007-11-16 16:41 UTC (permalink / raw)
To: Christoph Egger, xen-devel
That doesn't work so well on non-bsd, where libossaudio appears not to
exist. Does upstream qemu have a solution for this we could pull down?
-- Keir
On 15/11/07 14:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>
> Hi!
>
> Attached patch fixes the following linking error which I am seeing on BSD:
>
> ossaudio.o: In function `oss_open':
> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined reference to
> `_oss_ioctl'
> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined reference to
> `_oss_ioctl'
> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined reference to
> `_oss_ioctl'
> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined reference to
> `_oss_ioctl'
> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined reference to
> `_oss_ioctl'
> ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
> undefined references to `_oss_ioctl' follow
>
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TOOLS] ioemu: build fix
2007-11-16 16:41 ` Keir Fraser
@ 2007-11-16 17:22 ` Christoph Egger
2007-11-16 17:49 ` Keir Fraser
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Egger @ 2007-11-16 17:22 UTC (permalink / raw)
To: xen-devel
On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
> That doesn't work so well on non-bsd, where libossaudio appears not to
> exist. Does upstream qemu have a solution for this we could pull down?
I don't know. I haven't looked at it. I noticed this dependency on my BSD
machine, where I don't have SDL installed. On the BSD machine where I have
SDL installed, SDL is linked against ossaudio and therefore inherited
_oss_ioctl and I didn't notice this dependency earlier.
> -- Keir
>
> On 15/11/07 14:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > Hi!
> >
> > Attached patch fixes the following linking error which I am seeing on
> > BSD:
> >
> > ossaudio.o: In function `oss_open':
> > /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined
> > reference to `_oss_ioctl'
> > /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined
> > reference to `_oss_ioctl'
> > /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined
> > reference to `_oss_ioctl'
> > /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined
> > reference to `_oss_ioctl'
> > /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined
> > reference to `_oss_ioctl'
> > ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
> > undefined references to `_oss_ioctl' follow
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TOOLS] ioemu: build fix
2007-11-16 17:22 ` Christoph Egger
@ 2007-11-16 17:49 ` Keir Fraser
2007-11-22 10:38 ` Christoph Egger
0 siblings, 1 reply; 6+ messages in thread
From: Keir Fraser @ 2007-11-16 17:49 UTC (permalink / raw)
To: Christoph Egger, xen-devel
It seems that libossaudio is a bsd-specific ossaudio compat library. Either
you need to make extra -lossaudio specific to *bsd, or you need to
auto-detect presence of the library (somehow). Or maybe both.
-- Keir
On 16/11/07 17:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
>> That doesn't work so well on non-bsd, where libossaudio appears not to
>> exist. Does upstream qemu have a solution for this we could pull down?
>
> I don't know. I haven't looked at it. I noticed this dependency on my BSD
> machine, where I don't have SDL installed. On the BSD machine where I have
> SDL installed, SDL is linked against ossaudio and therefore inherited
> _oss_ioctl and I didn't notice this dependency earlier.
>
>> -- Keir
>>
>> On 15/11/07 14:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>>> Hi!
>>>
>>> Attached patch fixes the following linking error which I am seeing on
>>> BSD:
>>>
>>> ossaudio.o: In function `oss_open':
>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined
>>> reference to `_oss_ioctl'
>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined
>>> reference to `_oss_ioctl'
>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined
>>> reference to `_oss_ioctl'
>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined
>>> reference to `_oss_ioctl'
>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined
>>> reference to `_oss_ioctl'
>>> ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
>>> undefined references to `_oss_ioctl' follow
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TOOLS] ioemu: build fix
2007-11-16 17:49 ` Keir Fraser
@ 2007-11-22 10:38 ` Christoph Egger
2007-11-22 10:43 ` Keir Fraser
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Egger @ 2007-11-22 10:38 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel
Revision 1.217 in qemu looks promising, though I haven't tested it:
http://cvs.savannah.nongnu.org/viewvc/qemu/Makefile.target?root=qemu&r1=1.216&r2=1.217
Christoph
On Friday 16 November 2007 18:49:11 Keir Fraser wrote:
> It seems that libossaudio is a bsd-specific ossaudio compat library. Either
> you need to make extra -lossaudio specific to *bsd, or you need to
> auto-detect presence of the library (somehow). Or maybe both.
>
> -- Keir
>
> On 16/11/07 17:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
> >> That doesn't work so well on non-bsd, where libossaudio appears not to
> >> exist. Does upstream qemu have a solution for this we could pull down?
> >
> > I don't know. I haven't looked at it. I noticed this dependency on my BSD
> > machine, where I don't have SDL installed. On the BSD machine where I
> > have SDL installed, SDL is linked against ossaudio and therefore
> > inherited _oss_ioctl and I didn't notice this dependency earlier.
> >
> >> -- Keir
> >>
> >> On 15/11/07 14:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >>> Hi!
> >>>
> >>> Attached patch fixes the following linking error which I am seeing on
> >>> BSD:
> >>>
> >>> ossaudio.o: In function `oss_open':
> >>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined
> >>> reference to `_oss_ioctl'
> >>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined
> >>> reference to `_oss_ioctl'
> >>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined
> >>> reference to `_oss_ioctl'
> >>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined
> >>> reference to `_oss_ioctl'
> >>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined
> >>> reference to `_oss_ioctl'
> >>> ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
> >>> undefined references to `_oss_ioctl' follow
> >>>
> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >>
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xensource.com
> >> http://lists.xensource.com/xen-devel
--
AMD Saxony, Dresden, Germany
Operating System Research Center
Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TOOLS] ioemu: build fix
2007-11-22 10:38 ` Christoph Egger
@ 2007-11-22 10:43 ` Keir Fraser
0 siblings, 0 replies; 6+ messages in thread
From: Keir Fraser @ 2007-11-22 10:43 UTC (permalink / raw)
To: Christoph Egger; +Cc: xen-devel
Doesn't look to me like it addresses this issue.
-- Keir
On 22/11/07 10:38, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>
> Revision 1.217 in qemu looks promising, though I haven't tested it:
> http://cvs.savannah.nongnu.org/viewvc/qemu/Makefile.target?root=qemu&r1=1.216&
> r2=1.217
>
> Christoph
>
> On Friday 16 November 2007 18:49:11 Keir Fraser wrote:
>> It seems that libossaudio is a bsd-specific ossaudio compat library. Either
>> you need to make extra -lossaudio specific to *bsd, or you need to
>> auto-detect presence of the library (somehow). Or maybe both.
>>
>> -- Keir
>>
>> On 16/11/07 17:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>>> On Friday 16 November 2007 17:41:20 Keir Fraser wrote:
>>>> That doesn't work so well on non-bsd, where libossaudio appears not to
>>>> exist. Does upstream qemu have a solution for this we could pull down?
>>>
>>> I don't know. I haven't looked at it. I noticed this dependency on my BSD
>>> machine, where I don't have SDL installed. On the BSD machine where I
>>> have SDL installed, SDL is linked against ossaudio and therefore
>>> inherited _oss_ioctl and I didn't notice this dependency earlier.
>>>
>>>> -- Keir
>>>>
>>>> On 15/11/07 14:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>>>>> Hi!
>>>>>
>>>>> Attached patch fixes the following linking error which I am seeing on
>>>>> BSD:
>>>>>
>>>>> ossaudio.o: In function `oss_open':
>>>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:223: undefined
>>>>> reference to `_oss_ioctl'
>>>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:228: undefined
>>>>> reference to `_oss_ioctl'
>>>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:234: undefined
>>>>> reference to `_oss_ioctl'
>>>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:239: undefined
>>>>> reference to `_oss_ioctl'
>>>>> /root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:245: undefined
>>>>> reference to `_oss_ioctl'
>>>>> ossaudio.o:/root/xen-staging.hg/tools/ioemu/audio/ossaudio.c:251: more
>>>>> undefined references to `_oss_ioctl' follow
>>>>>
>>>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>>
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@lists.xensource.com
>>>> http://lists.xensource.com/xen-devel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-11-22 10:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-15 14:00 [PATCH][TOOLS] ioemu: build fix Christoph Egger
2007-11-16 16:41 ` Keir Fraser
2007-11-16 17:22 ` Christoph Egger
2007-11-16 17:49 ` Keir Fraser
2007-11-22 10:38 ` Christoph Egger
2007-11-22 10:43 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.