From: "John W. Linville" <linville@tuxdriver.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers
Date: Thu, 15 Nov 2007 16:31:18 -0500 [thread overview]
Message-ID: <20071115213118.GE12902@tuxdriver.com> (raw)
In-Reply-To: <1194829690.31574.70.camel@debian.sh.intel.com>
On Mon, Nov 12, 2007 at 09:08:10AM +0800, Zhu Yi wrote:
>=20
> On Sat, 2007-11-10 at 20:49 +0100, Miguel Bot=F3n wrote:
> > Remove unnecesary code in iwl3945 and iwl4965 drivers.
> >=20
> > "final_mode" variable is already initialized with the value of the
> > "mode" variable.
> >=20
> > Signed-off-by: Miguel Boton <mboton@gmail.com>
>=20
> ACK. Or you can do "u32 uninitialized_var(final_mode);". Both are OK
> with me.
I think I like this alternative better...
--=20
John W. Linville
linville@tuxdriver.com
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers
Date: Thu, 15 Nov 2007 16:31:18 -0500 [thread overview]
Message-ID: <20071115213118.GE12902@tuxdriver.com> (raw)
In-Reply-To: <1194829690.31574.70.camel@debian.sh.intel.com>
On Mon, Nov 12, 2007 at 09:08:10AM +0800, Zhu Yi wrote:
>
> On Sat, 2007-11-10 at 20:49 +0100, Miguel Botón wrote:
> > Remove unnecesary code in iwl3945 and iwl4965 drivers.
> >
> > "final_mode" variable is already initialized with the value of the
> > "mode" variable.
> >
> > Signed-off-by: Miguel Boton <mboton@gmail.com>
>
> ACK. Or you can do "u32 uninitialized_var(final_mode);". Both are OK
> with me.
I think I like this alternative better...
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-11-15 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 19:49 [PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers Miguel Botón
2007-11-10 19:49 ` Miguel Botón
2007-11-12 1:08 ` Zhu Yi
2007-11-12 1:08 ` Zhu Yi
2007-11-15 21:31 ` John W. Linville [this message]
2007-11-15 21:31 ` John W. Linville
2007-11-15 21:31 ` [PATCH] iwlwifi: remove redundant initialization of final_mode John W. Linville
2007-11-15 21:31 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115213118.GE12902@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mboton.lkml@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.