All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Cc: kexec-ml <kexec@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] Add the array length of "free_list" for filtering free pages
Date: Fri, 16 Nov 2007 11:16:30 -0800	[thread overview]
Message-ID: <20071116191624.GD8971@verge.net.au> (raw)
In-Reply-To: <473D0176.6090702@mxs.nes.nec.co.jp>

On Fri, Nov 16, 2007 at 11:33:26AM +0900, Ken'ichi Ohmichi wrote:
> 
> This patch adds the array length of "free_area.free_list" to the vmcoreinfo
> data so that makedumpfile (dump filtering command) can exclude all free pages
> in linux-2.6.24.
> 
> makedumpfile creates a small dumpfile by excluding unnecessary pages for the
> analysis. To distinguish unnecessary pages, makedumpfile gets the vmcoreinfo
> data which has the minimum debugging information only for dump filtering.
> 
> In 2.6.24-rc1 or later, the free_area.free_list is an array which has one list
> for each migrate types instead of a single list. makedumpfile needs the array
> length of "free_area.free_list" and the vmcoreinfo data should contain it.
> 
> 
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> Tested-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>

This seems fine to me. Though from a point of maintainability
would it be better if VMCOREINFO_LENGTH derived the length
from the element of the type in question. Just a thought,
I haven't hacked it up to see how practical it might be.

Acked-by: Simon Horman <horms@verge.net.au>

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
Cc: lkml <linux-kernel@vger.kernel.org>,
	kexec-ml <kexec@lists.infradead.org>
Subject: Re: [PATCH 5/5] Add the array length of "free_list" for filtering free pages
Date: Fri, 16 Nov 2007 11:16:30 -0800	[thread overview]
Message-ID: <20071116191624.GD8971@verge.net.au> (raw)
In-Reply-To: <473D0176.6090702@mxs.nes.nec.co.jp>

On Fri, Nov 16, 2007 at 11:33:26AM +0900, Ken'ichi Ohmichi wrote:
> 
> This patch adds the array length of "free_area.free_list" to the vmcoreinfo
> data so that makedumpfile (dump filtering command) can exclude all free pages
> in linux-2.6.24.
> 
> makedumpfile creates a small dumpfile by excluding unnecessary pages for the
> analysis. To distinguish unnecessary pages, makedumpfile gets the vmcoreinfo
> data which has the minimum debugging information only for dump filtering.
> 
> In 2.6.24-rc1 or later, the free_area.free_list is an array which has one list
> for each migrate types instead of a single list. makedumpfile needs the array
> length of "free_area.free_list" and the vmcoreinfo data should contain it.
> 
> 
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> Tested-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>

This seems fine to me. Though from a point of maintainability
would it be better if VMCOREINFO_LENGTH derived the length
from the element of the type in question. Just a thought,
I haven't hacked it up to see how practical it might be.

Acked-by: Simon Horman <horms@verge.net.au>

  reply	other threads:[~2007-11-16 19:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <473CFE14.3010400@mxs.nes.nec.co.jp>
2007-11-16  2:33 ` [PATCH 1/5] Rename vmcoreinfo's macros returning the size Ken'ichi Ohmichi
2007-11-16  2:33   ` Ken'ichi Ohmichi
2007-11-16 18:26   ` Simon Horman
2007-11-16 18:26     ` Simon Horman
2007-11-16  2:33 ` [PATCH 2/5] Use the existing offsetof() for VMCOREINFO_OFFSET() Ken'ichi Ohmichi
2007-11-16  2:33   ` Ken'ichi Ohmichi
2007-11-16 18:54   ` Simon Horman
2007-11-16 18:54     ` Simon Horman
2007-11-16  2:33 ` [PATCH 3/5] Add "VMCOREINFO_" to all the call for vmcoreinfo_append_str() Ken'ichi Ohmichi
2007-11-16  2:33   ` Ken'ichi Ohmichi
2007-11-16 18:55   ` Simon Horman
2007-11-16 18:55     ` Simon Horman
2007-11-16  2:33 ` [PATCH 4/5] Fix the configuration dependencies Ken'ichi Ohmichi
2007-11-16  2:33   ` Ken'ichi Ohmichi
2007-11-16 16:25   ` Simon Horman
2007-11-16 16:25     ` Simon Horman
2007-11-21  2:50     ` Ken'ichi Ohmichi
2007-11-21  2:50       ` Ken'ichi Ohmichi
2007-11-26  7:58   ` Andrew Morton
2007-11-26  7:58     ` Andrew Morton
2007-11-27  9:38     ` Ken'ichi Ohmichi
2007-11-27  9:38       ` Ken'ichi Ohmichi
2007-11-27 18:18       ` Christoph Lameter
2007-11-27 18:18         ` Christoph Lameter
2007-11-16  2:33 ` [PATCH 5/5] Add the array length of "free_list" for filtering free pages Ken'ichi Ohmichi
2007-11-16  2:33   ` Ken'ichi Ohmichi
2007-11-16 19:16   ` Simon Horman [this message]
2007-11-16 19:16     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071116191624.GD8971@verge.net.au \
    --to=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oomichi@mxs.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.