From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] autoconf: Add tests for memmem, strtoumax and mkdtemp functions
Date: Wed, 21 Nov 2007 01:58:58 -0500 [thread overview]
Message-ID: <20071121065858.GU14735@spearce.org> (raw)
In-Reply-To: <200711191947.05960.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote:
> By the way, do you have idea how to test for the following
> in configure.ac:
>
> * Define NO_PREAD if you have a problem with pread() system call (e.g.
> cygwin.dll before v1.5.22).
>
> - what is the problem? how to detect it?
This also appears to be broken on HP-UX (e.g. we need to set
NO_PREAD there). Thiago on IRC talked about this the other day
when he was trying to build git on a bunch of different systems.
Unfortunately this may just need to be an OS based test. The code
compiles just fine but when index-pack tries to use pread to walk
back through the deltas and generate their SHA-1s it barfs without
an error code. I suspect the failure is pread claiming it put the
data into the user buffer but not actually doing so, which causes
zlib's inflate() to then see data corruption.
Ouch.
--
Shawn.
next prev parent reply other threads:[~2007-11-21 6:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 18:47 [PATCH] autoconf: Add tests for memmem, strtoumax and mkdtemp functions Jakub Narebski
2007-11-21 6:58 ` Shawn O. Pearce [this message]
2007-11-21 18:47 ` Jakub Narebski
[not found] ` <7vd4u5l29v.fsf@gitster.siamese.dyndns.org>
2007-11-20 18:12 ` Stefan-W. Hahn
2007-11-21 0:08 ` Matt Kraai
2007-12-05 15:45 ` [PATCH/RFC] autoconf: Add test for OLD_ICONV Jakub Narebski
2007-12-05 16:11 ` Brian Gernhardt
2007-12-05 16:33 ` Jakub Narebski
2007-12-05 16:31 ` Wincent Colaiuta
2007-12-05 16:52 ` Jakub Narebski
2007-12-05 20:49 ` Wincent Colaiuta
2007-12-05 21:19 ` Jakub Narebski
2007-12-05 21:38 ` Brian Gernhardt
2007-12-06 19:07 ` Wincent Colaiuta
2007-12-05 19:38 ` Junio C Hamano
2007-12-05 21:26 ` Jakub Narebski
2007-12-05 22:22 ` Junio C Hamano
2007-12-05 23:05 ` [PATCH/RFC (amend)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-05 23:27 ` Junio C Hamano
2007-12-05 21:46 ` [PATCH/RFC] autoconf: Add test for OLD_ICONV Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121065858.GU14735@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.