From: Pascal Obry <pascal@obry.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Arjen Laarhoven <arjen@yaph.org>,
Brian Gernhardt <benji@silverinsanity.com>
Subject: Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV
Date: Wed, 05 Dec 2007 22:46:51 +0100 [thread overview]
Message-ID: <47571C4B.5060907@obry.net> (raw)
In-Reply-To: <1196869526-2197-1-git-send-email-jnareb@gmail.com>
Jakub Narebski a écrit :
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This patch needs checking if it correctly sets OLD_ICONV
> when needed. I have checked only that it is not set when
> with new iconv() declaration. Could people using Cygwin
> (and other with OLD_ICONV: Darwin) test it?
Not working on Cygwin:
$ autoconf
$ ./configure --prefix=/usr/local --build=i686-pc-cygwin
...
configure: CHECKS for header files
checking for old iconv()... no
It should be yes above. And in config.mak.autogen we have:
OLD_ICONV=
Note also that you should remove all the hard-coded settings in Makefile
anyway.
Pascal.
--
--|------------------------------------------------------
--| Pascal Obry Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--| http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595
next prev parent reply other threads:[~2007-12-05 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 18:47 [PATCH] autoconf: Add tests for memmem, strtoumax and mkdtemp functions Jakub Narebski
[not found] ` <7vd4u5l29v.fsf@gitster.siamese.dyndns.org>
2007-11-20 18:12 ` Stefan-W. Hahn
2007-11-21 0:08 ` Matt Kraai
2007-12-05 15:45 ` [PATCH/RFC] autoconf: Add test for OLD_ICONV Jakub Narebski
2007-12-05 16:11 ` Brian Gernhardt
2007-12-05 16:33 ` Jakub Narebski
2007-12-05 16:31 ` Wincent Colaiuta
2007-12-05 16:52 ` Jakub Narebski
2007-12-05 20:49 ` Wincent Colaiuta
2007-12-05 21:19 ` Jakub Narebski
2007-12-05 21:38 ` Brian Gernhardt
2007-12-06 19:07 ` Wincent Colaiuta
2007-12-05 19:38 ` Junio C Hamano
2007-12-05 21:26 ` Jakub Narebski
2007-12-05 22:22 ` Junio C Hamano
2007-12-05 23:05 ` [PATCH/RFC (amend)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-05 23:27 ` Junio C Hamano
2007-12-05 21:46 ` Pascal Obry [this message]
2007-11-21 6:58 ` [PATCH] autoconf: Add tests for memmem, strtoumax and mkdtemp functions Shawn O. Pearce
2007-11-21 18:47 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47571C4B.5060907@obry.net \
--to=pascal@obry.net \
--cc=arjen@yaph.org \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.