From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close
Date: Wed, 21 Nov 2007 09:43:50 -0600 [thread overview]
Message-ID: <20071121094350.44a18e26@weaponx> (raw)
In-Reply-To: <20071121154123.GB23589@lst.de>
On Wed, 21 Nov 2007 16:41:23 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote:
> > It's a bad idea to call flush_scheduled_work from within a
> > netdev->stop because the linkwatch will occasionally take the
> > rtnl lock from a workqueue context, and thus that can deadlock.
> >
> > This reworks things a bit in that area to avoid the problem.
>
> So from the name of the driver you want to keep the previous emac
> driver around. Is there a good reason for that?
It's being kept around until arch/ppc dies. Then things should get
renamed.
josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
netdev@vger.kernel.org, jgarzik@pobox.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close
Date: Wed, 21 Nov 2007 09:43:50 -0600 [thread overview]
Message-ID: <20071121094350.44a18e26@weaponx> (raw)
In-Reply-To: <20071121154123.GB23589@lst.de>
On Wed, 21 Nov 2007 16:41:23 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote:
> > It's a bad idea to call flush_scheduled_work from within a
> > netdev->stop because the linkwatch will occasionally take the
> > rtnl lock from a workqueue context, and thus that can deadlock.
> >
> > This reworks things a bit in that area to avoid the problem.
>
> So from the name of the driver you want to keep the previous emac
> driver around. Is there a good reason for that?
It's being kept around until arch/ppc dies. Then things should get
renamed.
josh
next prev parent reply other threads:[~2007-11-21 15:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 6:06 [PATCH 0/8] ibm_newemac: Candidate patches for 2.6.25 Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 1/8] ibm_newemac: Fix possible lockup on close Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 15:41 ` Christoph Hellwig
2007-11-21 15:43 ` Josh Boyer [this message]
2007-11-21 15:43 ` Josh Boyer
2007-11-21 19:53 ` Benjamin Herrenschmidt
2007-11-21 19:53 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 2/8] ibm_newemac: Add BCM5248 and Marvell 88E1111 PHY support Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 3/8] ibm_newemac: Add ET1011c " Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 4/8] ibm_newemac: Fix ZMII refcounting bug Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 5/8] ibm_newemac: Workaround reset timeout when no link Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 6/8] ibm_newemac: Cleanup/Fix RGMII MDIO support detection Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 8/8] ibm_newemac: Skip EMACs that are marked unused by the firmware Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-21 7:13 ` Stefan Roese
2007-11-21 7:13 ` Stefan Roese
2007-11-21 7:28 ` Benjamin Herrenschmidt
2007-11-21 6:06 ` [PATCH 7/8] ibm_newemac: Cleanup/fix support for STACR register variants Benjamin Herrenschmidt
2007-11-21 6:06 ` Benjamin Herrenschmidt
2007-11-24 1:43 ` [PATCH 0/8] ibm_newemac: Candidate patches for 2.6.25 Jeff Garzik
2007-11-24 1:43 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121094350.44a18e26@weaponx \
--to=jwboyer@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.