From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] [Mini-OS] Fix stack closures
Date: Fri, 23 Nov 2007 15:47:16 +0000 [thread overview]
Message-ID: <20071123154716.GA11563@implementation.uk.xensource.com> (raw)
So as to make backtracing tools happy, correctly close x86 stacks for
new threads as well as on callback in the x86_32 case since there is no
unwind marker.
Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>
diff -r 2e05a6173be0 extras/mini-os/arch/x86/x86_32.S
--- a/extras/mini-os/arch/x86/x86_32.S Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_32.S Fri Nov 23 15:40:40 2007 +0000
@@ -125,6 +125,7 @@
cmpl $ecrit,%eax
jb critical_region_fixup
11: push %esp
+ xorl %ebp,%ebp
call do_hypervisor_callback
add $4,%esp
movl HYPERVISOR_shared_info,%esi
@@ -280,6 +281,8 @@
ENTRY(thread_starter)
popl %eax
popl %ebx
+ pushl $0
+ xorl %ebp,%ebp
pushl %eax
call *%ebx
call exit_thread
--- a/extras/mini-os/arch/x86/x86_64.S Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_64.S Fri Nov 23 15:40:40 2007 +0000
@@ -379,6 +378,8 @@
ENTRY(thread_starter)
popq %rdi
popq %rbx
+ pushq $0
+ xorq %rbp,%rbp
call *%rbx
call exit_thread
reply other threads:[~2007-11-23 15:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123154716.GA11563@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.