* [PATCH] [Mini-OS] Fix stack closures
@ 2007-11-23 15:47 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2007-11-23 15:47 UTC (permalink / raw)
To: xen-devel
So as to make backtracing tools happy, correctly close x86 stacks for
new threads as well as on callback in the x86_32 case since there is no
unwind marker.
Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>
diff -r 2e05a6173be0 extras/mini-os/arch/x86/x86_32.S
--- a/extras/mini-os/arch/x86/x86_32.S Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_32.S Fri Nov 23 15:40:40 2007 +0000
@@ -125,6 +125,7 @@
cmpl $ecrit,%eax
jb critical_region_fixup
11: push %esp
+ xorl %ebp,%ebp
call do_hypervisor_callback
add $4,%esp
movl HYPERVISOR_shared_info,%esi
@@ -280,6 +281,8 @@
ENTRY(thread_starter)
popl %eax
popl %ebx
+ pushl $0
+ xorl %ebp,%ebp
pushl %eax
call *%ebx
call exit_thread
--- a/extras/mini-os/arch/x86/x86_64.S Fri Nov 23 11:58:11 2007 +0000
+++ b/extras/mini-os/arch/x86/x86_64.S Fri Nov 23 15:40:40 2007 +0000
@@ -379,6 +378,8 @@
ENTRY(thread_starter)
popq %rdi
popq %rbx
+ pushq $0
+ xorq %rbp,%rbp
call *%rbx
call exit_thread
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-23 15:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-23 15:47 [PATCH] [Mini-OS] Fix stack closures Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.