From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] [Mini-OS] Make semaphores callback-safe
Date: Fri, 23 Nov 2007 16:45:03 +0000 [thread overview]
Message-ID: <20071123164503.GA12130@implementation.uk.xensource.com> (raw)
One may want to use semaphores in event handlers to wake threads waiting
for a resource, so semaphores then need to be callback-safe.
Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>
---
Note: there is no such use in the current code, but I have an overflow
fix for netfront which depends on this.
diff -r f2711b7eae95 -r 36bf1e737b87 extras/mini-os/include/semaphore.h
--- a/extras/mini-os/include/semaphore.h Thu Nov 22 19:55:42 2007 +0000
+++ b/extras/mini-os/include/semaphore.h Fri Nov 23 13:21:02 2007 +0000
@@ -41,14 +41,25 @@
static void inline down(struct semaphore *sem)
{
- wait_event(sem->wait, sem->count > 0);
+ unsigned long flags;
+ while (1) {
+ wait_event(sem->wait, sem->count > 0);
+ local_irq_save(flags);
+ if (sem->count > 0)
+ break;
+ local_irq_restore(flags);
+ }
sem->count--;
+ local_irq_restore(flags);
}
static void inline up(struct semaphore *sem)
{
+ unsigned long flags;
+ local_irq_save(flags);
sem->count++;
wake_up(&sem->wait);
+ local_irq_restore(flags);
}
/* FIXME! Thre read/write semaphores are unimplemented! */
reply other threads:[~2007-11-23 16:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123164503.GA12130@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.