* [PATCH] [Mini-OS] Make semaphores callback-safe
@ 2007-11-23 16:45 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2007-11-23 16:45 UTC (permalink / raw)
To: xen-devel
One may want to use semaphores in event handlers to wake threads waiting
for a resource, so semaphores then need to be callback-safe.
Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>
---
Note: there is no such use in the current code, but I have an overflow
fix for netfront which depends on this.
diff -r f2711b7eae95 -r 36bf1e737b87 extras/mini-os/include/semaphore.h
--- a/extras/mini-os/include/semaphore.h Thu Nov 22 19:55:42 2007 +0000
+++ b/extras/mini-os/include/semaphore.h Fri Nov 23 13:21:02 2007 +0000
@@ -41,14 +41,25 @@
static void inline down(struct semaphore *sem)
{
- wait_event(sem->wait, sem->count > 0);
+ unsigned long flags;
+ while (1) {
+ wait_event(sem->wait, sem->count > 0);
+ local_irq_save(flags);
+ if (sem->count > 0)
+ break;
+ local_irq_restore(flags);
+ }
sem->count--;
+ local_irq_restore(flags);
}
static void inline up(struct semaphore *sem)
{
+ unsigned long flags;
+ local_irq_save(flags);
sem->count++;
wake_up(&sem->wait);
+ local_irq_restore(flags);
}
/* FIXME! Thre read/write semaphores are unimplemented! */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-11-23 16:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-23 16:45 [PATCH] [Mini-OS] Make semaphores callback-safe Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.