All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Fix non-optimized compilation of Xen's memcmp
Date: Fri, 23 Nov 2007 17:54:14 +0000	[thread overview]
Message-ID: <20071123175414.GA12424@implementation.uk.xensource.com> (raw)

Even when using __builtin_memcmp, gcc may emit external references to
memcmp (when not optimizing for instance), so this #define does not
always provide a completely suitable memcmp().

Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com>

diff -r 0eae1f245c8d xen/include/asm-x86/string.h
--- a/xen/include/asm-x86/string.h	Fri Nov 23 17:41:00 2007 +0000
+++ b/xen/include/asm-x86/string.h	Fri Nov 23 17:50:51 2007 +0000
@@ -109,7 +109,6 @@ void *__memcpy(void *t, const void *f, s
 #define __HAVE_ARCH_MEMMOVE
 extern void *memmove(void *dest, const void *src, size_t n);
 
-#define __HAVE_ARCH_MEMCMP
 #define memcmp __builtin_memcmp
 
 static inline void *__memset_generic(void *s, char c, size_t count)

                 reply	other threads:[~2007-11-23 17:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071123175414.GA12424@implementation.uk.xensource.com \
    --to=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.