From: Matt Mackall <mpm@selenic.com>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Simon Arlott <simon@fire.lp0.eu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()
Date: Fri, 23 Nov 2007 14:09:13 -0600 [thread overview]
Message-ID: <20071123200913.GE19691@waste.org> (raw)
In-Reply-To: <20071123195410.GA11401@2ka.mipt.ru>
On Fri, Nov 23, 2007 at 10:54:11PM +0300, Evgeniy Polyakov wrote:
> On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall (mpm@selenic.com) wrote:
> > Here's another thought: move all this logic into the networking core,
> > unify it with current softirq zapper, then allow it to be called from
> > various other places (like atomic allocators). Then it'll all be in
> > central maintained place with more users.
>
> This can be done quite easily - put a check into __kfree_skb() if
> netpoll is compiled-in and we are in hardirq context, then put skb
> into softirq freeing queue. Then zap_completion_queue() can free
> anything without ever knowing about nature of the packet, since this
> will be checked in __kfree_skb() anyway.
What I had in mind was moving the whole zap_completion_queue concept
into net/core/skbuff. So that netpoll (and, say, atomic kmalloc) can
simply call something like "clean_completion_queue".
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-11-23 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 19:47 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable() Simon Arlott
2007-11-23 8:21 ` Andrew Morton
2007-11-23 10:55 ` Evgeniy Polyakov
2007-11-23 17:07 ` Matt Mackall
2007-11-23 17:57 ` Evgeniy Polyakov
2007-11-23 18:48 ` Evgeniy Polyakov
2007-11-23 18:51 ` Evgeniy Polyakov
2007-11-23 18:59 ` Evgeniy Polyakov
2007-11-23 19:11 ` Matt Mackall
2007-11-23 19:32 ` Evgeniy Polyakov
2007-11-23 19:41 ` Matt Mackall
2007-11-23 19:54 ` Evgeniy Polyakov
2007-11-23 20:07 ` Evgeniy Polyakov
2007-11-23 20:09 ` Matt Mackall [this message]
2007-11-24 18:19 ` Matt Mackall
2007-11-23 18:59 ` Matt Mackall
2007-11-23 19:15 ` Evgeniy Polyakov
2007-11-23 19:20 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123200913.GE19691@waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.