All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Miguel Botón" <mboton.lkml@gmail.com>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	yi.zhu@intel.com
Subject: Re: [PATCH 2/2] iwlwifi: add power management support -v2
Date: Mon, 26 Nov 2007 17:18:14 +0100	[thread overview]
Message-ID: <200711261718.14711.mboton@gmail.com> (raw)
In-Reply-To: <1ba2fa240711162215p30b8bc7fj9f36020378ff596a@mail.gmail.com>

On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote:
> Why power management shouldn't be enabled while in AC? The semantic o=
f this
> ioctls is quite unclear.

IWL_POWER_AC and IWL_POWER_BATTERY are just two power modes. IWL_POWER_=
AC=20
would be the default power mode when we're in AC (no power saving) and=20
IWL_POWER_BATTERY would be the default power mode when we're in battery=
=20
(power saving mode). That's why we set IWL_POWER_ENABLED flag with=20
IWL_POWER_BATTERY, because it is the only power mode that saves power.

We can change to IWL_POWER_BATTERY or IWL_POWER_AC in any moment.

This patch, depending if power management is enabled or not, sets which=
 power=20
mode we should use, Then, it checks if we're already using this mode or=
 not.

--=20
	Miguel Bot=F3n
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Miguel Botón" <mboton.lkml@gmail.com>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "Miguel Botón" <mboton.lkml@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	yi.zhu@intel.com
Subject: Re: [PATCH 2/2] iwlwifi: add power management support -v2
Date: Mon, 26 Nov 2007 17:18:14 +0100	[thread overview]
Message-ID: <200711261718.14711.mboton@gmail.com> (raw)
In-Reply-To: <1ba2fa240711162215p30b8bc7fj9f36020378ff596a@mail.gmail.com>

On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote:
> Why power management shouldn't be enabled while in AC? The semantic of this
> ioctls is quite unclear.

IWL_POWER_AC and IWL_POWER_BATTERY are just two power modes. IWL_POWER_AC 
would be the default power mode when we're in AC (no power saving) and 
IWL_POWER_BATTERY would be the default power mode when we're in battery 
(power saving mode). That's why we set IWL_POWER_ENABLED flag with 
IWL_POWER_BATTERY, because it is the only power mode that saves power.

We can change to IWL_POWER_BATTERY or IWL_POWER_AC in any moment.

This patch, depending if power management is enabled or not, sets which power 
mode we should use, Then, it checks if we're already using this mode or not.

-- 
	Miguel Botón

  parent reply	other threads:[~2007-11-26 16:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16 23:06 [PATCH 2/2] iwlwifi: add power management support -v2 Miguel Botón
2007-11-16 23:06 ` Miguel Botón
     [not found] ` <1ba2fa240711162215p30b8bc7fj9f36020378ff596a@mail.gmail.com>
2007-11-26 16:18   ` Miguel Botón [this message]
2007-11-26 16:18     ` Miguel Botón
2007-11-26 17:11     ` Tomas Winkler
2007-11-26 17:11       ` Tomas Winkler
2007-11-26 17:14       ` Dan Williams
2007-11-26 17:14         ` Dan Williams
2007-11-26 17:33         ` Tomas Winkler
2007-11-26 17:33           ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711261718.14711.mboton@gmail.com \
    --to=mboton.lkml@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.