From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org,
ralf@linux-mips.org, James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28
Date: Tue, 27 Nov 2007 10:01:39 +0100 [thread overview]
Message-ID: <20071127090139.GA6933@alpha.franken.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0711270927370.22167@anakin>
On Tue, Nov 27, 2007 at 09:28:14AM +0100, Geert Uytterhoeven wrote:
> > struct hpc_chunk {
> > struct hpc_dma_desc desc;
> > - u32 _padding; /* align to quadword boundary */
> > + u32 _padding[128/4 - 3]; /* align to biggest cache line size */
> ^^^^^^^^^
> (128 - sizeof(struct hpc_dma_desc))/4?
yes, that's safer. Thank you.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2007-11-27 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 17:41 [PATCH] SGIWD93: use cached memory access to make driver work on IP28 Thomas Bogendoerfer
2007-11-27 8:28 ` Geert Uytterhoeven
2007-11-27 9:01 ` Thomas Bogendoerfer [this message]
2007-11-27 23:00 ` peter fuerst
2007-11-27 23:36 ` Thomas Bogendoerfer
2007-11-28 9:50 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071127090139.GA6933@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.