From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-scsi@vger.kernel.org, linux-mips@linux-mips.org,
James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] SGIWD93: use cached memory access to make driver work on IP28
Date: Wed, 28 Nov 2007 09:50:09 +0000 [thread overview]
Message-ID: <20071128095009.GA11063@linux-mips.org> (raw)
In-Reply-To: <20071126223921.A566CC2B26@solo.franken.de>
On Mon, Nov 26, 2007 at 06:41:15PM +0100, Thomas Bogendoerfer wrote:
> Following patch is 2.6.25 material needed to get SGI IP28 machines
> supported.
>
> Thomas.
>
> SGI IP28 machines would need special treatment (enable adding addtional
> wait states) when accessing memory uncached. To avoid this pain I
> changed the driver to use only cached access to memory.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Same comment as for SGISEEQ: IP28 is clearly a maximum weirdo beast.
Technically the patch looks fine it's just a few stilistic issues such as
there no reason for DMA_SYNC_DESC_CPU and DMA_SYNC_DESC_DEV being macros
so why not using inlines.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
prev parent reply other threads:[~2007-11-28 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 17:41 [PATCH] SGIWD93: use cached memory access to make driver work on IP28 Thomas Bogendoerfer
2007-11-27 8:28 ` Geert Uytterhoeven
2007-11-27 9:01 ` Thomas Bogendoerfer
2007-11-27 23:00 ` peter fuerst
2007-11-27 23:36 ` Thomas Bogendoerfer
2007-11-28 9:50 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128095009.GA11063@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.