All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] PATCH: fix Makefile issue with make 3.79
@ 2007-11-26 13:24 Tristan Gingold
  2007-11-28 10:24 ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Tristan Gingold @ 2007-11-26 13:24 UTC (permalink / raw)
  To: qemu-devel

$^ is all dependencies (ie the .c and .h files in dyngen case).
Because there is only one .c file to compile, this patch will work in  
all cases.

Tristan.


diff -c -r1.136 Makefile
*** Makefile	24 Nov 2007 23:35:07 -0000	1.136
--- Makefile	26 Nov 2007 13:17:41 -0000
***************
*** 132,138 ****

   # dyngen host tool
   dyngen$(EXESUF): dyngen.c
! 	$(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $^

   clean:
   # avoid old build problems by removing potentially incorrect old  
files
--- 132,138 ----

   # dyngen host tool
   dyngen$(EXESUF): dyngen.c
! 	$(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $<

   clean:
   # avoid old build problems by removing potentially incorrect old  
files

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] PATCH: fix Makefile issue with make 3.79
  2007-11-26 13:24 [Qemu-devel] PATCH: fix Makefile issue with make 3.79 Tristan Gingold
@ 2007-11-28 10:24 ` Mike Frysinger
  2007-11-28 10:43   ` Tristan Gingold
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2007-11-28 10:24 UTC (permalink / raw)
  To: qemu-devel; +Cc: Tristan Gingold

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

On Monday 26 November 2007, Tristan Gingold wrote:
> $^ is all dependencies (ie the .c and .h files in dyngen case).
> Because there is only one .c file to compile, this patch will work in
> all cases.

why not simply upgrade your make to something that is not known to be broken 
and something that isnt ~7 years old.  make-3.80 was released over 5 years 
ago.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] PATCH: fix Makefile issue with make 3.79
  2007-11-28 10:24 ` Mike Frysinger
@ 2007-11-28 10:43   ` Tristan Gingold
  0 siblings, 0 replies; 3+ messages in thread
From: Tristan Gingold @ 2007-11-28 10:43 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: qemu-devel


On Nov 28, 2007, at 11:24 AM, Mike Frysinger wrote:

> On Monday 26 November 2007, Tristan Gingold wrote:
>> $^ is all dependencies (ie the .c and .h files in dyngen case).
>> Because there is only one .c file to compile, this patch will work in
>> all cases.
>
> why not simply upgrade your make to something that is not known to  
> be broken
> and something that isnt ~7 years old.  make-3.80 was released over  
> 5 years
> ago.

Sure, but the proposed patch is not that ugly !

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-11-28 10:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-26 13:24 [Qemu-devel] PATCH: fix Makefile issue with make 3.79 Tristan Gingold
2007-11-28 10:24 ` Mike Frysinger
2007-11-28 10:43   ` Tristan Gingold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.