* [PATCH 1/4]: Use AF-independent rebuild_header routine
@ 2007-11-28 8:35 Gerrit Renker
2007-11-28 13:19 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Renker @ 2007-11-28 8:35 UTC (permalink / raw)
To: dccp
[DCCP]: Use AF-independent rebuild_header routine
This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and DCCPv6, but uses
inet_sk_rebuild_header() in each case. This leads to unpredictable and weird behaviour:
under some conditions, DCCPv6 Resets were sent, in other not.
The fix is to use the AF-independent rebuild_header routine.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/dccp/output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/dccp/output.c
+++ b/net/dccp/output.c
@@ -391,7 +391,7 @@ int dccp_send_reset(struct sock *sk, enu
* FIXME: what if rebuild_header fails?
* Should we be doing a rebuild_header here?
*/
- int err = inet_sk_rebuild_header(sk);
+ int err = inet_csk(sk)->icsk_af_ops->rebuild_header(sk);
if (err != 0)
return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4]: Use AF-independent rebuild_header routine
2007-11-28 8:35 [PATCH 1/4]: Use AF-independent rebuild_header routine Gerrit Renker
@ 2007-11-28 13:19 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2007-11-28 13:19 UTC (permalink / raw)
To: dccp
Em Wed, Nov 28, 2007 at 08:35:08AM +0000, Gerrit Renker escreveu:
> [DCCP]: Use AF-independent rebuild_header routine
>
> This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and DCCPv6, but uses
> inet_sk_rebuild_header() in each case. This leads to unpredictable and weird behaviour:
> under some conditions, DCCPv6 Resets were sent, in other not.
>
> The fix is to use the AF-independent rebuild_header routine.
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-28 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-28 8:35 [PATCH 1/4]: Use AF-independent rebuild_header routine Gerrit Renker
2007-11-28 13:19 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.