From: Jeff Dike <jdike@addtoit.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] leak in do_ubd_request
Date: Wed, 28 Nov 2007 10:03:38 -0500 [thread overview]
Message-ID: <20071128150338.GA5501@c2.user-mode-linux.org> (raw)
In-Reply-To: <E1IxJMf-00067v-2r@dorka.pomaz.szeredi.hu>
On Wed, Nov 28, 2007 at 10:37:53AM +0100, Miklos Szeredi wrote:
> > Do we have any idea which patch this patch fixes?
>
> I seems like a mainline bug, and has been present for some time
> (forever?).
>
> I have no idea why this wasn't noticed earlier.
Not forever, but it's been there for a while - it was introduced here:
commit 2adcec2197897365e0a0f657f1098cbfdb44bc8b
Author: Jeff Dike <jdike@addtoit.com>
Date: Sun May 6 14:51:37 2007 -0700
uml: send pointers instead of structures to I/O thread
Instead of writing entire structures between UML and the I/O thread, we send
pointers. This cuts down on the amount of data being copied and possibly
allows more requests to be pending between the two.
This requires that the requests be kmalloced and freed instead of living on
the stack.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] leak in do_ubd_request
Date: Wed, 28 Nov 2007 10:03:38 -0500 [thread overview]
Message-ID: <20071128150338.GA5501@c2.user-mode-linux.org> (raw)
In-Reply-To: <E1IxJMf-00067v-2r@dorka.pomaz.szeredi.hu>
On Wed, Nov 28, 2007 at 10:37:53AM +0100, Miklos Szeredi wrote:
> > Do we have any idea which patch this patch fixes?
>
> I seems like a mainline bug, and has been present for some time
> (forever?).
>
> I have no idea why this wasn't noticed earlier.
Not forever, but it's been there for a while - it was introduced here:
commit 2adcec2197897365e0a0f657f1098cbfdb44bc8b
Author: Jeff Dike <jdike@addtoit.com>
Date: Sun May 6 14:51:37 2007 -0700
uml: send pointers instead of structures to I/O thread
Instead of writing entire structures between UML and the I/O thread, we send
pointers. This cuts down on the amount of data being copied and possibly
allows more requests to be pending between the two.
This requires that the requests be kmalloced and freed instead of living on
the stack.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2007-11-28 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 16:23 [uml-devel] leak in do_ubd_request Miklos Szeredi
2007-11-27 16:23 ` Miklos Szeredi
2007-11-27 18:26 ` [uml-devel] " Miklos Szeredi
2007-11-27 18:26 ` Miklos Szeredi
2007-11-27 20:11 ` [uml-devel] " Jeff Dike
2007-11-27 20:11 ` Jeff Dike
2007-11-27 20:29 ` Miklos Szeredi
2007-11-27 20:29 ` Miklos Szeredi
2007-11-27 22:20 ` Jeff Dike
2007-11-28 5:38 ` Andrew Morton
2007-11-28 9:37 ` Miklos Szeredi
2007-11-28 9:37 ` Miklos Szeredi
2007-11-28 15:03 ` Jeff Dike [this message]
2007-11-28 15:03 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071128150338.GA5501@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.