All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: David Chinner <dgc@sgi.com>,
	akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>,
	Mel Gorman <mel@skynet.ie>,
	William Lee Irwin III <wli@holomorphy.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Badari Pulavarty <pbadari@gmail.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Fengguang Wu <fengguang.wu@gmail.com>,
	swin wang <wangswin@gmail.com>,
	totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org
Subject: Re: [patch 14/19] Use page_cache_xxx in ext2
Date: Thu, 29 Nov 2007 15:19:50 +1100	[thread overview]
Message-ID: <20071129041950.GH119954183@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711282014590.20688@schroedinger.engr.sgi.com>

On Wed, Nov 28, 2007 at 08:15:26PM -0800, Christoph Lameter wrote:
> On Thu, 29 Nov 2007, David Chinner wrote:
> 
> > I don't think that gives the same return value. The return value
> > is supposed to be clamped at a maximum of page_cache_size(mapping).
> 
> Ok. So this?

Looks good.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

WARNING: multiple messages have this Message-ID (diff)
From: David Chinner <dgc@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: David Chinner <dgc@sgi.com>,
	akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>,
	Mel Gorman <mel@skynet.ie>,
	William Lee Irwin III <wli@holomorphy.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Badari Pulavarty <pbadari@gmail.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Fengguang Wu <fengguang.wu@gmail.com>,
	swin wang <wangswin@gmail.com>,
	totty.lu@gmail.com, hugh@veritas.com, joern@lazybastard.org
Subject: Re: [patch 14/19] Use page_cache_xxx in ext2
Date: Thu, 29 Nov 2007 15:19:50 +1100	[thread overview]
Message-ID: <20071129041950.GH119954183@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711282014590.20688@schroedinger.engr.sgi.com>

On Wed, Nov 28, 2007 at 08:15:26PM -0800, Christoph Lameter wrote:
> On Thu, 29 Nov 2007, David Chinner wrote:
> 
> > I don't think that gives the same return value. The return value
> > is supposed to be clamped at a maximum of page_cache_size(mapping).
> 
> Ok. So this?

Looks good.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-11-29  4:20 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  1:10 [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions Christoph Lameter
2007-11-29  1:10 ` Christoph Lameter
2007-11-29  1:10 ` [patch 01/19] Define functions for page cache handling Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  3:06   ` David Chinner
2007-11-29  3:06     ` David Chinner
2007-11-29  3:21     ` Christoph Lameter
2007-11-29  3:21       ` Christoph Lameter
2007-11-29  8:44   ` Fengguang Wu
2007-11-29  8:44     ` Fengguang Wu
2007-11-29  8:44       ` Fengguang Wu
2007-11-29 19:23       ` Christoph Lameter
2007-11-29 19:23         ` Christoph Lameter
2007-11-29  1:10 ` [patch 02/19] Use page_cache_xxx functions in mm/filemap.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  1:10 ` [patch 03/19] Use page_cache_xxx in mm/page-writeback.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  1:10 ` [patch 04/19] Use page_cache_xxx in mm/truncate.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  1:10 ` [patch 05/19] Use page_cache_xxx in mm/rmap.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  3:19   ` David Chinner
2007-11-29  3:19     ` David Chinner
2007-11-29  3:30     ` Christoph Lameter
2007-11-29  3:30       ` Christoph Lameter
2007-11-29  3:59       ` David Chinner
2007-11-29  3:59         ` David Chinner
2007-11-29  4:09         ` Christoph Lameter
2007-11-29  4:09           ` Christoph Lameter
2007-11-29  4:11           ` David Chinner
2007-11-29  4:11             ` David Chinner
2007-11-29  1:10 ` [patch 06/19] Use page_cache_xxx in mm/filemap_xip.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  9:18   ` Fengguang Wu
2007-11-29  9:18     ` Fengguang Wu
2007-11-29  9:18       ` Fengguang Wu
2007-11-29  1:10 ` [patch 07/19] Use page_cache_xxx in mm/migrate.c Christoph Lameter
2007-11-29  1:10   ` Christoph Lameter
2007-11-29  1:11 ` [patch 08/19] Use page_cache_xxx in fs/libfs.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  1:11 ` [patch 09/19] Use page_cache_xxx in fs/sync Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  1:11 ` [patch 10/19] Use page_cache_xxx in fs/buffer.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:34   ` David Chinner
2007-11-29  3:34     ` David Chinner
2007-11-29  3:48     ` Christoph Lameter
2007-11-29  3:48       ` Christoph Lameter
2007-11-29  4:01       ` David Chinner
2007-11-29  4:01         ` David Chinner
2007-11-29  1:11 ` [patch 11/19] Use page_cache_xxx in mm/mpage.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  1:11 ` [patch 12/19] Use page_cache_xxx in mm/fadvise.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  1:11 ` [patch 13/19] Use page_cache_xxx in fs/splice.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:40   ` David Chinner
2007-11-29  3:40     ` David Chinner
2007-11-29  3:50     ` Christoph Lameter
2007-11-29  3:50       ` Christoph Lameter
2007-11-29  4:02       ` David Chinner
2007-11-29  4:02         ` David Chinner
2007-11-29  1:11 ` [patch 14/19] Use page_cache_xxx in ext2 Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:45   ` David Chinner
2007-11-29  3:45     ` David Chinner
2007-11-29  3:55     ` Christoph Lameter
2007-11-29  3:55       ` Christoph Lameter
2007-11-29  4:06       ` David Chinner
2007-11-29  4:06         ` David Chinner
2007-11-29  4:15         ` Christoph Lameter
2007-11-29  4:15           ` Christoph Lameter
2007-11-29  4:19           ` David Chinner [this message]
2007-11-29  4:19             ` David Chinner
2007-11-29  1:11 ` [patch 15/19] Use page_cache_xxx in fs/ext3 Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  1:11 ` [patch 16/19] Use page_cache_xxx in fs/ext4 Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:48   ` David Chinner
2007-11-29  3:48     ` David Chinner
2007-11-29  3:58     ` Christoph Lameter
2007-11-29  3:58       ` Christoph Lameter
2007-11-29  4:07       ` David Chinner
2007-11-29  4:07         ` David Chinner
2007-11-29  1:11 ` [patch 17/19] Use page_cache_xxx in fs/reiserfs Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:54   ` David Chinner
2007-11-29  3:54     ` David Chinner
2007-11-29  4:02     ` Christoph Lameter
2007-11-29  4:02       ` Christoph Lameter
2007-11-29  4:08       ` David Chinner
2007-11-29  4:08         ` David Chinner
2007-11-29  1:11 ` [patch 18/19] Use page_cache_xxx for fs/xfs Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  3:03   ` David Chinner
2007-11-29  3:03     ` David Chinner
2007-11-29  3:28     ` Christoph Lameter
2007-11-29  3:28       ` Christoph Lameter
2007-11-29  3:58       ` David Chinner
2007-11-29  3:58         ` David Chinner
2007-11-29  4:06         ` Christoph Lameter
2007-11-29  4:06           ` Christoph Lameter
2007-11-29  4:10           ` David Chinner
2007-11-29  4:10             ` David Chinner
2007-11-29  8:24             ` Andrew Morton
2007-11-29  8:24               ` Andrew Morton
2007-11-29  1:11 ` [patch 19/19] Use page_cache_xxx in drivers/block/rd.c Christoph Lameter
2007-11-29  1:11   ` Christoph Lameter
2007-11-29  8:32   ` Fengguang Wu
2007-11-29  8:32     ` Fengguang Wu
2007-11-29  8:32       ` Fengguang Wu
2007-11-29  4:20 ` [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions David Chinner
2007-11-29  4:20   ` David Chinner
2007-11-29  8:29   ` Andrew Morton
2007-11-29  8:29     ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2007-11-30 17:34 [patch 00/19] Page cache: Replace PAGE_CACHE_xx with inline functions V2 Christoph Lameter
2007-11-30 17:35 ` [patch 14/19] Use page_cache_xxx in ext2 Christoph Lameter
2007-11-30 17:35   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129041950.GH119954183@sgi.com \
    --to=dgc@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=fengguang.wu@gmail.com \
    --cc=hch@lst.de \
    --cc=hugh@veritas.com \
    --cc=jens.axboe@oracle.com \
    --cc=joern@lazybastard.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mel@skynet.ie \
    --cc=pbadari@gmail.com \
    --cc=totty.lu@gmail.com \
    --cc=wangswin@gmail.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.