From: Olof Johansson <olof@lixom.net>
To: Li Li <r64360@freescale.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Kumar Gala <kumar.gala@freescale.com>
Subject: Re: [PATCH] Add MPC837xEMDS PCIE RC mode support
Date: Thu, 29 Nov 2007 22:14:04 -0600 [thread overview]
Message-ID: <20071130041404.GB26982@lixom.net> (raw)
In-Reply-To: <1196394334.29683.5.camel@Guyver>
Hi,
On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote:
> + pci2@e0009000 {
Why call it pci2@ (and pci3@ below)? They are clearly identifiable with
their unit addresses anyway.
> +config PPC_MPC83XX_PCIE
> + bool "MPC837X PCI Express support"
> + depends on PCIEPORTBUS && PPC_MPC837x
> + default n
> + help
> + Enables MPC837x PCI express RC mode
Why have a separate config option for this?
For systems where you don't want PCI-e configured, it should be left
out of the device tree instead.
-Olof
next prev parent reply other threads:[~2007-11-30 4:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:45 [PATCH] Add MPC837xEMDS PCIE RC mode support Li Li
2007-11-30 4:14 ` Olof Johansson [this message]
2007-11-30 5:33 ` Li Li
2007-11-30 15:12 ` Scott Wood
2007-11-30 7:37 ` Kumar Gala
2007-11-30 8:48 ` Li Li
2007-11-30 9:05 ` Kumar Gala
2007-11-30 9:37 ` Li Li
2007-11-30 14:57 ` Kumar Gala
2007-11-30 15:19 ` Scott Wood
2007-12-03 3:43 ` Li Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071130041404.GB26982@lixom.net \
--to=olof@lixom.net \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=r64360@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.