All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Kumar Gala <kumar.gala@freescale.com>,
	Li Li <r64360@freescale.com>
Subject: Re: [PATCH] Add MPC837xEMDS PCIE RC mode support
Date: Fri, 30 Nov 2007 09:12:01 -0600	[thread overview]
Message-ID: <20071130151201.GA29484@loki.buserror.net> (raw)
In-Reply-To: <20071130041404.GB26982@lixom.net>

On Thu, Nov 29, 2007 at 10:14:04PM -0600, Olof Johansson wrote:
> On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote:
> > +	help
> > +	  Enables MPC837x PCI express RC mode
> 
> Why have a separate config option for this?

To save code size when it isn't needed?

> For systems where you don't want PCI-e configured, it should be left
> out of the device tree instead.

The dts should represent what exists on the hardware, not what you want to
use.

-Scott

  parent reply	other threads:[~2007-11-30 15:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30  3:45 [PATCH] Add MPC837xEMDS PCIE RC mode support Li Li
2007-11-30  4:14 ` Olof Johansson
2007-11-30  5:33   ` Li Li
2007-11-30 15:12   ` Scott Wood [this message]
2007-11-30  7:37 ` Kumar Gala
2007-11-30  8:48   ` Li Li
2007-11-30  9:05     ` Kumar Gala
2007-11-30  9:37       ` Li Li
2007-11-30 14:57         ` Kumar Gala
2007-11-30 15:19           ` Scott Wood
2007-12-03  3:43           ` Li Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071130151201.GA29484@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=kumar.gala@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=r64360@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.