All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix
Date: Sun, 02 Dec 2007 20:36:47 +0000	[thread overview]
Message-ID: <200712022136.48511.rjw@sisk.pl> (raw)
In-Reply-To: <20071202162814.GZ13717@jupiter.solarsys.private>

On Sunday, 2 of December 2007, Mark M. Hoffman wrote:
> Hi:
> 
> * Rafael J. Wysocki <rjw@sisk.pl> [2007-12-01 00:51:40 +0100]:
> > On Saturday, 1 of December 2007, Rafael J. Wysocki wrote:
> > > On Friday, 30 of November 2007, Jiri Slaby wrote:
> > > > On 11/30/2007 11:15 PM, Jean Delvare wrote:

[--snip--]
> 
> PS: while reading kernel/power/disk.c, I saw this...
> 
> 335 static void power_down(void)
> 336 {
> 337         switch (hibernation_mode) {
> 338         case HIBERNATION_TEST:
> 339         case HIBERNATION_TESTPROC:
> 340                 break;
> 341         case HIBERNATION_REBOOT:
> 342                 kernel_restart(NULL);
> 343                 break;
> 344         case HIBERNATION_PLATFORM:
> 345                 hibernation_platform_enter();
> 346         case HIBERNATION_SHUTDOWN:
> 347                 kernel_power_off();
> 348                 break;
> 349         }
> 350         kernel_halt();
> 351         /*
> 352          * Valid image is on the disk, if we continue we risk serious data
> 353          * corruption after resume.
> 354          */
> 355         printk(KERN_CRIT "Please power me down manually\n");
> 356         while(1);
> 357 }
> 
> Shouldn't that be while(1) cpu_relax(); ?

Yes, it should.

Thanks for pointing that out, I'll fix it.

Greetings,
Rafael

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix
Date: Sun, 2 Dec 2007 21:36:47 +0100	[thread overview]
Message-ID: <200712022136.48511.rjw@sisk.pl> (raw)
In-Reply-To: <20071202162814.GZ13717@jupiter.solarsys.private>

On Sunday, 2 of December 2007, Mark M. Hoffman wrote:
> Hi:
> 
> * Rafael J. Wysocki <rjw@sisk.pl> [2007-12-01 00:51:40 +0100]:
> > On Saturday, 1 of December 2007, Rafael J. Wysocki wrote:
> > > On Friday, 30 of November 2007, Jiri Slaby wrote:
> > > > On 11/30/2007 11:15 PM, Jean Delvare wrote:

[--snip--]
> 
> PS: while reading kernel/power/disk.c, I saw this...
> 
> 335 static void power_down(void)
> 336 {
> 337         switch (hibernation_mode) {
> 338         case HIBERNATION_TEST:
> 339         case HIBERNATION_TESTPROC:
> 340                 break;
> 341         case HIBERNATION_REBOOT:
> 342                 kernel_restart(NULL);
> 343                 break;
> 344         case HIBERNATION_PLATFORM:
> 345                 hibernation_platform_enter();
> 346         case HIBERNATION_SHUTDOWN:
> 347                 kernel_power_off();
> 348                 break;
> 349         }
> 350         kernel_halt();
> 351         /*
> 352          * Valid image is on the disk, if we continue we risk serious data
> 353          * corruption after resume.
> 354          */
> 355         printk(KERN_CRIT "Please power me down manually\n");
> 356         while(1);
> 357 }
> 
> Shouldn't that be while(1) cpu_relax(); ?

Yes, it should.

Thanks for pointing that out, I'll fix it.

Greetings,
Rafael

  reply	other threads:[~2007-12-02 20:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 14:14 [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix Jiri Slaby
2007-11-30 16:46 ` Rafael J. Wysocki
2007-11-30 21:36   ` Andrew Morton
2007-11-30 21:36     ` Andrew Morton
2007-11-30 22:15 ` [lm-sensors] " Jean Delvare
2007-11-30 22:15   ` Jean Delvare
2007-11-30 22:19   ` Jiri Slaby
2007-11-30 22:19     ` Jiri Slaby
2007-11-30 23:45     ` Rafael J. Wysocki
2007-11-30 23:45       ` Rafael J. Wysocki
2007-11-30 23:51       ` Rafael J. Wysocki
2007-11-30 23:51         ` Rafael J. Wysocki
2007-12-02 16:28         ` Mark M. Hoffman
2007-12-02 16:28           ` Mark M. Hoffman
2007-12-02 20:36           ` Rafael J. Wysocki [this message]
2007-12-02 20:36             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712022136.48511.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mhoffman@lightlink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.