All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pierre Ossman <drzeus@drzeus.cx>, Al Viro <viro@ftp.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>,
	linux-arch@vger.kernel.org
Subject: Re: Correct types for mod_devicetable.h (was: Re: m68k build failure)
Date: Mon, 3 Dec 2007 21:02:19 +1100	[thread overview]
Message-ID: <200712032102.20353.rusty@rustcorp.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0712021219430.29349@anakin>

On Sunday 02 December 2007 22:22:31 Geert Uytterhoeven wrote:
> On Sat, 1 Dec 2007, Pierre Ossman wrote:
> > Yeah, that could work. Have a header with stuff like this:
> >
> > typedef u16 __attribute__((aligned(2))) aligned_u16;
> > typedef u32 __attribute__((aligned(4))) aligned_u32;
>
> I gave it a try:

This seems to turn a molehill into a mountain.

We can change that mod_devicetable.h at any time; it's not supposed to be a 
userspace API (the kernel build system doesn't count).

So, just insert two bits of padding in sdio_device_id and insert a comment 
saying "/* Explicit padding: works even if we're cross-compiling */".

Thanks,
Rusty.

  reply	other threads:[~2007-12-03 10:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28  6:07 m68k build failure Andrew Morton
2007-11-28  8:48 ` Pierre Ossman
2007-11-28  9:00   ` Andrew Morton
2007-11-28  9:28     ` Al Viro
2007-11-28 12:29       ` Pierre Ossman
2007-11-28 12:34         ` Geert Uytterhoeven
2007-12-01 20:56           ` Pierre Ossman
2007-12-02 11:22             ` Correct types for mod_devicetable.h (was: Re: m68k build failure) Geert Uytterhoeven
2007-12-03 10:02               ` Rusty Russell [this message]
2007-12-08 21:58                 ` Adrian Bunk
2007-12-09  6:43                   ` Jon Masters
2007-12-09 17:10                   ` Pierre Ossman
2007-12-12  1:34                   ` Rusty Russell
2007-12-09 17:08               ` Pierre Ossman
2007-12-10 18:11                 ` Adrian Bunk
2007-12-10 19:12                   ` Pierre Ossman
2007-11-29 21:19       ` m68k build failure Andrew Morton
2007-11-30 17:55         ` Adrian Bunk
2007-11-28  9:24   ` Geert Uytterhoeven
2007-11-28  9:27     ` Geert Uytterhoeven
2007-11-28 10:01       ` Pierre Ossman
2007-11-28 10:07         ` Alan Cox
2007-11-28 10:23           ` Andreas Schwab
2007-11-28  9:58   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712032102.20353.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=drzeus@drzeus.cx \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sam@ravnborg.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.