All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] Unify mmap_[32|64].c
Date: Tue, 4 Dec 2007 22:36:36 +0100	[thread overview]
Message-ID: <20071204213636.GB11216@elte.hu> (raw)
In-Reply-To: <1196801553.10408.24.camel@brick>


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> x86: Unify mmap_32.c mmap_64.c
> 
> Start from mmap_32.c and add X86_64 specific function as well.

the principle looks good to me. A small detail: please send standard 
format patches, the following rename:

>  arch/x86/mm/{mmap_32.c => mmap.c} |   57 ++++++++++++++++++++-----------------

is a git extension and quilt does not know it.

	Ingo

  reply	other threads:[~2007-12-04 21:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-04 20:52 [RFC PATCH] Unify mmap_[32|64].c Harvey Harrison
2007-12-04 21:36 ` Ingo Molnar [this message]
2007-12-04 21:55   ` [RFC PATCHv2] " Harvey Harrison
2007-12-04 22:11     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071204213636.GB11216@elte.hu \
    --to=mingo@elte.hu \
    --cc=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.