From: Paul Mundt <lethal@linux-sh.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Olof Johansson <olof@lixom.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kumar Gala <galak@kernel.crashing.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g
Date: Wed, 5 Dec 2007 09:56:43 +0900 [thread overview]
Message-ID: <20071205005643.GA28860@linux-sh.org> (raw)
In-Reply-To: <20071204170745.GD15599@localhost.localdomain>
On Tue, Dec 04, 2007 at 08:07:45PM +0300, Anton Vorontsov wrote:
> This patch renames ioport_shift member of pata_platform_info
> structure to reg_shift. Users of pata_platform are followed
> appropriately.
>
> Rationale of that change is: shifting applies to the whole memory
> mapped region, not only to the command block of the ATA registers,
> despite the fact that shifting is meaningless for ctl register.
>
It's called ioport_shift because of the fact it shifts an ioport, namely
a struct ata_ioport *. We could rename it, but I really don't see the
point. If you don't like the choice of name on your platform, add a
comment to your platform-specific code noting this particular outrage so
it can be grepped for by future generations ;-)
Nacked-by: Paul Mundt <lethal@linux-sh.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Jeff Garzik <jeff@garzik.org>, Arnd Bergmann <arnd@arndb.de>,
linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g
Date: Wed, 5 Dec 2007 09:56:43 +0900 [thread overview]
Message-ID: <20071205005643.GA28860@linux-sh.org> (raw)
In-Reply-To: <20071204170745.GD15599@localhost.localdomain>
On Tue, Dec 04, 2007 at 08:07:45PM +0300, Anton Vorontsov wrote:
> This patch renames ioport_shift member of pata_platform_info
> structure to reg_shift. Users of pata_platform are followed
> appropriately.
>
> Rationale of that change is: shifting applies to the whole memory
> mapped region, not only to the command block of the ATA registers,
> despite the fact that shifting is meaningless for ctl register.
>
It's called ioport_shift because of the fact it shifts an ioport, namely
a struct ata_ioport *. We could rename it, but I really don't see the
point. If you don't like the choice of name on your platform, add a
comment to your platform-specific code noting this particular outrage so
it can be grepped for by future generations ;-)
Nacked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2007-12-05 0:57 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 17:04 [PATCH v2 0/4] OF-platform PATA driver Anton Vorontsov
2007-12-04 17:04 ` Anton Vorontsov
2007-12-04 17:06 ` [PATCH v2 1/4] [libata] pata_platform: make probe and remove functions device type neutral Anton Vorontsov
2007-12-04 17:06 ` Anton Vorontsov
2007-12-04 20:40 ` Olof Johansson
2007-12-04 20:40 ` Olof Johansson
2007-12-05 15:37 ` Anton Vorontsov
2007-12-05 15:37 ` Anton Vorontsov
2007-12-04 17:07 ` [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 18:48 ` Olof Johansson
2007-12-04 18:48 ` Olof Johansson
2007-12-04 19:49 ` Anton Vorontsov
2007-12-04 19:49 ` Anton Vorontsov
2007-12-04 20:01 ` Olof Johansson
2007-12-04 20:01 ` Olof Johansson
2007-12-04 20:37 ` Anton Vorontsov
2007-12-04 20:37 ` Anton Vorontsov
2007-12-04 20:39 ` Olof Johansson
2007-12-04 20:39 ` Olof Johansson
2007-12-05 0:48 ` Paul Mundt
2007-12-05 0:48 ` Paul Mundt
2007-12-05 3:26 ` Olof Johansson
2007-12-05 3:26 ` Olof Johansson
2007-12-05 18:39 ` Scott Wood
2007-12-05 18:39 ` Scott Wood
2007-12-14 8:23 ` Olof Johansson
2007-12-14 8:23 ` Olof Johansson
2007-12-14 16:09 ` Scott Wood
2007-12-14 16:09 ` Scott Wood
2007-12-14 16:33 ` Olof Johansson
2007-12-14 16:33 ` Olof Johansson
2007-12-04 17:07 ` [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 19:16 ` Olof Johansson
2007-12-04 19:16 ` Olof Johansson
2007-12-04 19:23 ` Scott Wood
2007-12-04 19:45 ` Anton Vorontsov
2007-12-04 19:45 ` Anton Vorontsov
2007-12-04 20:40 ` Olof Johansson
2007-12-04 20:40 ` Olof Johansson
2007-12-04 17:07 ` [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 17:08 ` Sergei Shtylyov
2007-12-04 17:08 ` Sergei Shtylyov
2007-12-05 0:56 ` Paul Mundt [this message]
2007-12-05 0:56 ` Paul Mundt
2007-12-04 20:44 ` [PATCH] pata_of_platform: Move electra-ide support over to new framework Olof Johansson
2007-12-04 20:44 ` Olof Johansson
2007-12-04 20:50 ` Jeff Garzik
2007-12-04 20:50 ` Jeff Garzik
2007-12-04 21:03 ` Olof Johansson
2007-12-04 21:03 ` Olof Johansson
2007-12-20 3:53 ` Paul Mackerras
2007-12-20 3:53 ` Paul Mackerras
2007-12-20 15:33 ` Olof Johansson
2007-12-20 15:33 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205005643.GA28860@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=arnd@arndb.de \
--cc=avorontsov@ru.mvista.com \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.