From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes
Date: Wed, 05 Dec 2007 13:55:11 +0000 [thread overview]
Message-ID: <20071205135511.GD893@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <11968535863312-git-send-email-gerrit@erg.abdn.ac.uk>
| > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru
| > if (unlikely(hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA)) {
| > if (is_data_packet) {
| > do_feedback = FBACK_INITIAL;
| > + hcrx->ccid3hcrx_s = payload_size;
| > ccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA);
| > - ccid3_hc_rx_update_s(hcrx, payload_size);
|
| We have to set ccid3hcrx_bytes_recv to the payload_size here too, I'm
| fixing this on the reworked patch that introduces the RX history.
|
I almost did the same error again by wanting to agree too prematurely.
But updating ccid3hcrx_bytes_recv is in fact not needed here and if it
would be done it would not have a useable effect. The reason is that the
first data packet will trigger the initial feedback; and in the initial
feedback packet X_recv (which is ccid3hcrx_bytes_recv / the_time_spent)
is set to 0 (RFC 3448, 6.3).
For this reason, updating bytes_recv for the first data packet is also not
in the flowchart on
http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ccid3_packet_reception/
WARNING: multiple messages have this Message-ID (diff)
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: Arnaldo Carvalho de Melo <acme@redhat.com>,
dccp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes
Date: Wed, 5 Dec 2007 13:55:11 +0000 [thread overview]
Message-ID: <20071205135511.GD893@gerrit.erg.abdn.ac.uk> (raw)
In-Reply-To: <20071205132345.GC4653@ghostprotocols.net>
| > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru
| > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {
| > if (is_data_packet) {
| > do_feedback = FBACK_INITIAL;
| > + hcrx->ccid3hcrx_s = payload_size;
| > ccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA);
| > - ccid3_hc_rx_update_s(hcrx, payload_size);
|
| We have to set ccid3hcrx_bytes_recv to the payload_size here too, I'm
| fixing this on the reworked patch that introduces the RX history.
|
I almost did the same error again by wanting to agree too prematurely.
But updating ccid3hcrx_bytes_recv is in fact not needed here and if it
would be done it would not have a useable effect. The reason is that the
first data packet will trigger the initial feedback; and in the initial
feedback packet X_recv (which is ccid3hcrx_bytes_recv / the_time_spent)
is set to 0 (RFC 3448, 6.3).
For this reason, updating bytes_recv for the first data packet is also not
in the flowchart on
http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ccid3_packet_reception/
next prev parent reply other threads:[~2007-12-05 13:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 11:19 [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 11:19 ` Gerrit Renker
2007-12-05 13:23 ` Arnaldo Carvalho de Melo
2007-12-05 13:23 ` Arnaldo Carvalho de Melo
2007-12-05 13:55 ` Gerrit Renker [this message]
2007-12-05 13:55 ` Gerrit Renker
2007-12-05 14:10 ` Arnaldo Carvalho de Melo
2007-12-05 14:10 ` Arnaldo Carvalho de Melo
2007-12-05 14:11 ` Arnaldo Carvalho de Melo
2007-12-05 14:11 ` Arnaldo Carvalho de Melo
2007-12-05 14:13 ` Arnaldo Carvalho de Melo
2007-12-05 14:13 ` Arnaldo Carvalho de Melo
2007-12-05 14:23 ` Arnaldo Carvalho de Melo
2007-12-05 14:23 ` Arnaldo Carvalho de Melo
2007-12-05 14:53 ` Gerrit Renker
2007-12-05 14:53 ` Gerrit Renker
2007-12-05 15:18 ` Arnaldo Carvalho de Melo
2007-12-05 15:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205135511.GD893@gerrit.erg.abdn.ac.uk \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.