All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Trolle Selander <trolle.selander@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A.
Date: Wed, 5 Dec 2007 14:24:46 +0000	[thread overview]
Message-ID: <20071205142446.GA12556@redhat.com> (raw)
In-Reply-To: <515922b50712040832ifc112b1j52e1d2390d7c7459@mail.gmail.com>

On Tue, Dec 04, 2007 at 05:32:39PM +0100, Trolle Selander wrote:
> This patch adds 16550 emulation to qemu-dm. I still consider it a work in
> progress, but from my testing, it consistently performs better than the old
> code already, sometimes considerably so (on my laptop, dumping out data over
> serial from a HVM DomU -> pty in Dom0 was up to 5.3 times faster than with
> the old 16450 code). I can consistenly reach full 115200 baud speeds over
> physical serial lines when the virtual device is backed by a phys port,
> which I never could with the old code.
> 
> There are still some things to be done. I want to add proper error handling,
> so that overflow/framing & parity errors on the physical port get detected
> and reported by the virtual port. Also, now that FIFOs are in place, I
> believe performance could be improved significantly by putting some code
> into the hypervisor so that reads & writes from the FIFOs don't have to exit
> into qemu-dm at all. I'm also reading up on the specs for newer uarts with
> deeper FIFOs.
> 
> However, for now, I think this patch is already quite good, and I don't
> think I should sit on it any longer. I'm looking forward to hearing what
> results others will get with it.

>From a quick glance through the patches there doesn't appear to be anything 
that is Xen specific in these patches. If I am correct in this understanding,
could you send the patches to upstream qemu-devel mailing lists, so Xen does
not have to carry this fork forever.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

  parent reply	other threads:[~2007-12-05 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-04 16:32 [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A Trolle Selander
2007-12-04 16:48 ` Alan Cox
2007-12-04 18:06   ` Trolle Selander
2007-12-05 13:55 ` Keir Fraser
2007-12-05 14:24 ` Daniel P. Berrange [this message]
2007-12-05 14:35   ` Trolle Selander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071205142446.GA12556@redhat.com \
    --to=berrange@redhat.com \
    --cc=trolle.selander@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.