device-mapper ./WHATS_NEW lib/libdm-common.c

device-mapper ./WHATS_NEW lib/libdm-common.c

[agk]

CVSROOT:	/cvs/dm
Module name:	device-mapper
Changes by:	agk@sourceware.org	2007-12-05 18:57:34

Modified files:
	.              : WHATS_NEW 
	lib            : libdm-common.c 

Log message:
	Fix minimum readahead debug message.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/WHATS_NEW.diff?cvsroot=dm&r1=1.214&r2=1.215
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/lib/libdm-common.c.diff?cvsroot=dm&r1=1.54&r2=1.55

--- device-mapper/WHATS_NEW	2007/12/05 17:14:30	1.214
+++ device-mapper/WHATS_NEW	2007/12/05 18:57:33	1.215
@@ -1,5 +1,6 @@
 Version 1.02.24 -
 ===================================
+  Fix minimum readahead debug message.
 
 Version 1.02.23 - 5th December 2007
 ===================================
--- device-mapper/lib/libdm-common.c	2007/12/05 14:11:26	1.54
+++ device-mapper/lib/libdm-common.c	2007/12/05 18:57:34	1.55
@@ -438,8 +438,8 @@
 			return_0;
 
 		if (current_read_ahead > read_ahead) {
-			log_debug("%s: read ahead %" PRIu32
-				  " below minimum of %" PRIu32,
+			log_debug("%s: retaining kernel read ahead of %" PRIu32
+				  " (requested %" PRIu32 ")",           
 				  dev_name, current_read_ahead, read_ahead);
 			return 1;
 		}

device-mapper ./WHATS_NEW lib/libdm-common.c

[agk]

CVSROOT:	/cvs/dm
Module name:	device-mapper
Changes by:	agk@sourceware.org	2007-12-13 02:25:45

Modified files:
	.              : WHATS_NEW 
	lib            : libdm-common.c 

Log message:
	Report error when empty device name passed to readahead functions.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/WHATS_NEW.diff?cvsroot=dm&r1=1.216&r2=1.217
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/lib/libdm-common.c.diff?cvsroot=dm&r1=1.55&r2=1.56

--- device-mapper/WHATS_NEW	2007/12/05 22:45:56	1.216
+++ device-mapper/WHATS_NEW	2007/12/13 02:25:45	1.217
@@ -1,5 +1,6 @@
 Version 1.02.24 -
 ===================================
+  Report error when empty device name passed to readahead functions.
   Fix minimum readahead debug message.
 
 Version 1.02.23 - 5th December 2007
--- device-mapper/lib/libdm-common.c	2007/12/05 18:57:34	1.55
+++ device-mapper/lib/libdm-common.c	2007/12/13 02:25:45	1.56
@@ -382,6 +382,11 @@
 	int fd;
 	long read_ahead_long;
 
+	if (!*dev_name) {
+		log_error("Empty device name passed to BLKRAGET");
+		return 0;
+	}
+
 	if ((fd = _open_dev_node(dev_name)) < 0)
 		return_0;
 
@@ -406,6 +411,11 @@
 	int fd;
 	long read_ahead_long = (long) read_ahead;
 
+	if (!*dev_name) {
+		log_error("Empty device name passed to BLKRAGET");
+		return 0;
+	}
+
 	if ((fd = _open_dev_node(dev_name)) < 0)
 		return_0;
 

device-mapper ./WHATS_NEW lib/libdm-common.c

[agk]

CVSROOT:	/cvs/dm
Module name:	device-mapper
Changes by:	agk@sourceware.org	2007-12-14 17:26:09

Modified files:
	.              : WHATS_NEW 
	lib            : libdm-common.c 

Log message:
	Add node operation stack debug messages.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/WHATS_NEW.diff?cvsroot=dm&r1=1.217&r2=1.218
http://sourceware.org/cgi-bin/cvsweb.cgi/device-mapper/lib/libdm-common.c.diff?cvsroot=dm&r1=1.56&r2=1.57

--- device-mapper/WHATS_NEW	2007/12/13 02:25:45	1.217
+++ device-mapper/WHATS_NEW	2007/12/14 17:26:08	1.218
@@ -1,5 +1,6 @@
 Version 1.02.24 -
 ===================================
+  Add node operation stack debug messages.
   Report error when empty device name passed to readahead functions.
   Fix minimum readahead debug message.
 
--- device-mapper/lib/libdm-common.c	2007/12/13 02:25:45	1.56
+++ device-mapper/lib/libdm-common.c	2007/12/14 17:26:09	1.57
@@ -575,18 +575,25 @@
 int add_dev_node(const char *dev_name, uint32_t major, uint32_t minor,
 		 uid_t uid, gid_t gid, mode_t mode)
 {
+	log_debug("%s: Stacking NODE_ADD (%" PRIu32 ",%" PRIu32 ") %u:%u 0%o",
+		  dev_name, major, minor, uid, gid, mode);
+
 	return _stack_node_op(NODE_ADD, dev_name, major, minor, uid, gid, mode,
 			      "", 0, 0);
 }
 
 int rename_dev_node(const char *old_name, const char *new_name)
 {
+	log_debug("%s: Stacking NODE_RENAME to %s", old_name, new_name);
+
 	return _stack_node_op(NODE_RENAME, new_name, 0, 0, 0, 0, 0, old_name,
 			      0, 0);
 }
 
 int rm_dev_node(const char *dev_name)
 {
+	log_debug("%s: Stacking NODE_DEL", dev_name);
+
 	return _stack_node_op(NODE_DEL, dev_name, 0, 0, 0, 0, 0, "", 0, 0);
 }
 
@@ -596,6 +603,9 @@
 	if (read_ahead == DM_READ_AHEAD_AUTO)
 		return 1;
 
+	log_debug("%s: Stacking NODE_READ_AHEAD %" PRIu32 " (flags=%" PRIu32
+		  ")", dev_name, read_ahead, read_ahead_flags);
+
 	return _stack_node_op(NODE_READ_AHEAD, dev_name, 0, 0, 0, 0, 0, "",
 			      read_ahead, read_ahead_flags);
 }