From: Tony Lindgren <tony@atomide.com>
To: david.cohen@indt.org.br
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/1] OMAP System Control fix for OMAP2420
Date: Wed, 5 Dec 2007 14:45:45 -0800 [thread overview]
Message-ID: <20071205224545.GB4105@atomide.com> (raw)
In-Reply-To: <1196883889-18378-2-git-send-email-david.cohen@indt.org.br>
* david.cohen@indt.org.br <david.cohen@indt.org.br> [071205 11:59]:
> From: David Cohen <david.cohen@indt.org.br>
>
> OMAP2420 has a different offset for CONTROL_STATUS register.
>
> Signed-off-by: David Cohen <david.cohen@indt.org.br>
> ---
> include/asm-arm/arch-omap/control.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-arm/arch-omap/control.h b/include/asm-arm/arch-omap/control.h
> index 5f42725..8670d54 100644
> --- a/include/asm-arm/arch-omap/control.h
> +++ b/include/asm-arm/arch-omap/control.h
> @@ -37,7 +37,13 @@
>
> #define CONTROL_DEVCONF0 (CONTROL_GENERAL + 0x04)
> #define CONTROL_DEVCONF1 (CONTROL_GENERAL + 0x68) /* > 242x */
> +
> +/* OMAP2420's CONTROL_STATUS offset is 0x2F8 */
> +#ifdef CONFIG_ARCH_OMAP2420
> +#define CONTROL_STATUS (CONTROL_GENERAL + 0x88)
> +#else
> #define CONTROL_STATUS (CONTROL_GENERAL + 0x80)
> +#endif
>
Please no more ifdefs in headers for 24XX vs 3440. Instead, please
define OMAP2420_CONTROL_STATUS and OMAP2430_CONTROL_STATUS or
something like that.
Regards,
Tony
parent reply other threads:[~2007-12-05 22:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1196883889-18378-2-git-send-email-david.cohen@indt.org.br>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205224545.GB4105@atomide.com \
--to=tony@atomide.com \
--cc=david.cohen@indt.org.br \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.