* Re: [PATCH 1/1] OMAP System Control fix for OMAP2420
[not found] ` <1196883889-18378-2-git-send-email-david.cohen@indt.org.br>
@ 2007-12-05 22:45 ` Tony Lindgren
0 siblings, 0 replies; only message in thread
From: Tony Lindgren @ 2007-12-05 22:45 UTC (permalink / raw)
To: david.cohen; +Cc: linux-omap, linux-omap-open-source
* david.cohen@indt.org.br <david.cohen@indt.org.br> [071205 11:59]:
> From: David Cohen <david.cohen@indt.org.br>
>
> OMAP2420 has a different offset for CONTROL_STATUS register.
>
> Signed-off-by: David Cohen <david.cohen@indt.org.br>
> ---
> include/asm-arm/arch-omap/control.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-arm/arch-omap/control.h b/include/asm-arm/arch-omap/control.h
> index 5f42725..8670d54 100644
> --- a/include/asm-arm/arch-omap/control.h
> +++ b/include/asm-arm/arch-omap/control.h
> @@ -37,7 +37,13 @@
>
> #define CONTROL_DEVCONF0 (CONTROL_GENERAL + 0x04)
> #define CONTROL_DEVCONF1 (CONTROL_GENERAL + 0x68) /* > 242x */
> +
> +/* OMAP2420's CONTROL_STATUS offset is 0x2F8 */
> +#ifdef CONFIG_ARCH_OMAP2420
> +#define CONTROL_STATUS (CONTROL_GENERAL + 0x88)
> +#else
> #define CONTROL_STATUS (CONTROL_GENERAL + 0x80)
> +#endif
>
Please no more ifdefs in headers for 24XX vs 3440. Instead, please
define OMAP2420_CONTROL_STATUS and OMAP2430_CONTROL_STATUS or
something like that.
Regards,
Tony
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-05 22:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1196883889-18378-1-git-send-email-david.cohen@indt.org.br>
[not found] ` <1196883889-18378-2-git-send-email-david.cohen@indt.org.br>
2007-12-05 22:45 ` [PATCH 1/1] OMAP System Control fix for OMAP2420 Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.